Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle variable length lines with more than 125 columns after the header, especially for HiRA #78

Closed
21 tasks
venitahagerty opened this issue Mar 2, 2022 · 1 comment · Fixed by #79
Closed
21 tasks
Assignees
Labels
METdataio: Load STAT Data priority: blocker Blocker required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: bug Fix something that is not working

Comments

@venitahagerty
Copy link
Contributor

Describe the Problem

*With the new ability to apply the HiRA method to ensembles, some variable length lines can get much longer - theoretically to at least 2000 columns. If all input lines are treated as having the ability to have up to 2000 columns, more memory will be needed, and the program will be slower.

For now, the fix is to identify lines that will be too long, skip them, and give an error message.

Long term, it might be better to either increase the column limit or process long lines separately. Increasing the limit will require changes to the VSDB code.*

Expected Behavior

Provide a clear and concise description of what you expected to happen here.

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

Needed for release.

Funding Source

NONE

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Related to MET issue [https://github.com/dtcenter/MET/issues/1583]

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.
@venitahagerty venitahagerty added priority: blocker Blocker type: bug Fix something that is not working required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone METdataio: Load STAT Data labels Mar 2, 2022
@venitahagerty venitahagerty self-assigned this Mar 2, 2022
venitahagerty added a commit that referenced this issue Mar 7, 2022
Handle variable length lines with more than 125 columns after the header, especially for HiRA (issue #78)
@venitahagerty
Copy link
Contributor Author

Finished adding fix for lines too long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
METdataio: Load STAT Data priority: blocker Blocker required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: bug Fix something that is not working
Projects
None yet
1 participant