Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement various enhancements to climatology settings #1247

Closed
4 of 24 tasks
georgemccabe opened this issue Nov 9, 2021 · 0 comments · Fixed by #1385
Closed
4 of 24 tasks

Implement various enhancements to climatology settings #1247

georgemccabe opened this issue Nov 9, 2021 · 0 comments · Fixed by #1385
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: use case wrapper METplus: Configuration priority: high High Priority requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Nov 9, 2021

Various enhancements are needed to improve the logic for setting climatology variables in the climo_mean and climo_stdev dictionaries.

Describe the Enhancements

  • Add support for setting a list of field levels in climo variables

Setting the following:

GRID_STAT_CLIMO_MEAN_FIELD = {name="UGRD"; level=["P850","P500","P250"];}

Results in an improperly formatted value:

METPLUS_CLIMO_MEAN_DICT=climo_mean = {file_name = ["/scratch1/NCEPDEV/global/glopara/fix/fix_verif/climo_fi
les/cmean_1d.19591203"];field = [{name="UGRD"; level=["P850",P500,P250];}];}

Add a test for setting climo field info and enhance the logic to properly format a list of levels. Make sure the behavior works for all apps that use climatology variables.

  • Add support for using forecast or observation field info for climatology

It is often the case that the climatology field info is the same as the forecast field info. If <APP>_CLIMO_[MEAN/STDEV]_FIELD_NAME is not set, then the wrapper should check if <APP>_CLIMO_[MEAN/STDEV]_USE_[FCST/OBS] is set to True. Error out if both are True. If one is True, then use the field info from the appropriate input as the field info for the climo variable

  • Add support for setting file_type for climo_[mean/stdev]

Add optional <APP>_CLIMO_[MEAN/STDEV]_FILE_TYPE to set file_type in the appropriate climo dictionary -- this was implemented in PR #1353

Time Estimate

~1 day

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Nov 9, 2021
@georgemccabe georgemccabe added this to the METplus-4.1.0 milestone Nov 9, 2021
@georgemccabe georgemccabe self-assigned this Nov 9, 2021
@georgemccabe georgemccabe added component: use case wrapper METplus: Configuration priority: high High Priority requestor: NOAA/EMC NOAA Environmental Modeling Center and removed alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Nov 9, 2021
@georgemccabe georgemccabe changed the title Add support for setting a list of field levels in climo variables Implement various enhancements to climatology settings Nov 9, 2021
@georgemccabe georgemccabe added required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone and removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required labels Dec 7, 2021
georgemccabe added a commit that referenced this issue Jan 27, 2022
georgemccabe added a commit that referenced this issue Jan 27, 2022
georgemccabe added a commit that referenced this issue Jan 27, 2022
…ger adds unnecessary spaces after commas within quotation marks, ci-run-all-diff
georgemccabe added a commit that referenced this issue Jan 27, 2022
…ger adds unnecessary spaces after commas within quotation marks, ci-run-all-diff
georgemccabe added a commit that referenced this issue Jan 28, 2022
…for climo_mean or climo_stdev, added unit tests to ensure correct value is set
@georgemccabe georgemccabe linked a pull request Jan 28, 2022 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: use case wrapper METplus: Configuration priority: high High Priority requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant