Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for PB2NC_OBS_PREPBUFR_MAP #1431

Closed
9 of 20 tasks
georgemccabe opened this issue Feb 9, 2022 · 0 comments · Fixed by #1433
Closed
9 of 20 tasks

Remove support for PB2NC_OBS_PREPBUFR_MAP #1431

georgemccabe opened this issue Feb 9, 2022 · 0 comments · Fixed by #1433
Assignees
Labels
METplus: Configuration priority: high High Priority requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

Users are encouraged to set obs_bufr_map instead of obs_prepbufr_map. We should not support setting this variable if it is not recommended to use. This was added in 4.1.0-beta5, so we can remove it without too much trouble.

Describe the Enhancement

See above

Time Estimate

~1 hour

Relevant Deadlines

4.1.0

Funding Source

NONE

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing priority: high High Priority requestor: METplus Team METplus Development Team METplus: Configuration labels Feb 9, 2022
@georgemccabe georgemccabe added this to the METplus-4.1.0 milestone Feb 9, 2022
@georgemccabe georgemccabe self-assigned this Feb 9, 2022
georgemccabe added a commit that referenced this issue Feb 9, 2022
…se users should be setting obs_bufr_map instead
@georgemccabe georgemccabe linked a pull request Feb 9, 2022 that will close this issue
12 tasks
@jprestop jprestop mentioned this issue Feb 25, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
METplus: Configuration priority: high High Priority requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant