Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance logic for setting mask.poly to allow MET list characters (square braces and semi-colon) #966

Closed
8 of 21 tasks
georgemccabe opened this issue Jun 28, 2021 · 0 comments · Fixed by #1430
Closed
8 of 21 tasks
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle METplus: Configuration priority: medium Medium Priority requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

A question from Deanna Spindler in a NOAA telecon brought up an improvement to the logic that reads lists to be more flexible. The following value will produce an error because the logic for reading lists from the METplus config files automatically adds square braces and a semicolon:

POINT_STAT_POLY = [“{ENV[MET_BUILD_BASE]}/share/met/poly/CAR.poly”, "{ENV[MET_BUILD_BASE]}/share/met/poly/GLF.poly", "{ENV[MET_BUILD_BASE]}/share/met/poly/NAO.poly", "{ENV[MET_BUILD_BASE]}/share/met/poly/SAO.poly" ];

The correct format for this variable is currently:

POINT_STAT_POLY = “{ENV[MET_BUILD_BASE]}/share/met/poly/CAR.poly”, "{ENV[MET_BUILD_BASE]}/share/met/poly/GLF.poly", "{ENV[MET_BUILD_BASE]}/share/met/poly/NAO.poly", "{ENV[MET_BUILD_BASE]}/share/met/poly/SAO.poly"

however, it would be good to enhance the logic that parses a list to check if a semicolon and/or square braces already exist in the value and do not add them if so.

Describe the Enhancement

Add logic to the getlist (met_util) function to handle the formatting properly so that both of the above values would be handled properly.

Time Estimate

~1 day

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing component: use case configuration priority: medium Medium Priority requestor: NOAA/EMC NOAA Environmental Modeling Center alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle METplus: Configuration labels Jun 28, 2021
@georgemccabe georgemccabe added this to the METplus-4.1.0 milestone Jun 28, 2021
@georgemccabe georgemccabe self-assigned this Jun 28, 2021
georgemccabe added a commit that referenced this issue Feb 8, 2022
…values using VERIF_MASK that improperly formatted list values like POINT_STAT_MASK_POLY while preserving functionality to set deprecated env vars so that old wrapped MET config files still work, ci-run-all-diff
@georgemccabe georgemccabe linked a pull request Feb 9, 2022 that will close this issue
12 tasks
@georgemccabe georgemccabe changed the title Enhance logic for reading lists to handle different formats of input Enhance logic for setting mask.poly to allow MET list characters (square braces and semi-colon) Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle METplus: Configuration priority: medium Medium Priority requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants