Update Develop-ref after #1152 #1181

georgemccabe · 2021-09-29T16:20:21Z

Although the changes in Pull request #1152 did not change any use cases, there were external changes that created differences in the output.

Summary of differences

Commit 8a64233 involves a change to the GFDLTracker_Genesis and GFDLTracker_ETC use cases to use a different mean sea level pressure field (PRMSL instead of MSLET)
@CPKalb updated the sample data for the Blocking and WeatherRegime use cases that had been messed up somehow. While investigating this @CPKalb discovered that there was a discrepancy in the data -- the WeatherRegime data should be US only and the Blocking data should be global. Previously the same GFS data was used for both sets of use cases. @CPKalb mentioned adding a check to ensure the grids are the same between the input data sets.
- UserScript_fcstGFS_obsERA_Blocking - there is no output data for this case in the truth data, but there are output files after fixing the input data and paths in the conf files
- UserScript_obsERA_obsOnly_Blocking - the final output plots differ but this is expected because the correct domains for the input data are now being used
- UserScript_fcstGFS_obsERA_WeatherRegime - the s2s/fcst_weather_regime_class.txt slightly changed, but this is likely due to changes in input data described above

…on web server so develop-ref can check for new develop data

… dictionaries in GridStat (#858)

…nger used

…ip instead of custom version, added info to contrib guide about CI

Co-authored-by: George McCabe <[email protected]>

* Added section for ReadTheDocs, added basic info about the Release Guide and Verification Datasets Guide, but more information on those needs to be added later * Added information about the various versions available in the documentation * Updated the ReadTheDocs section with information on hidden branches and how to access them; Modified dtcenter.github.io references * Added section to add_use_case.rst about Accessing the Documentation and modified documentation.rst to indicate the docs can still be built manually * Modified format of list * Modified formatting * Changed GitHub Pages links to Read the Docs links * Modified formatting * Fixed typo * Updated Release Guide for Read The Docs * Took out duplicate data and consolidated sections * Update docs/Contributors_Guide/add_use_case.rst Removed sentence Co-authored-by: George McCabe <[email protected]> * Update docs/Contributors_Guide/add_use_case.rst Fixed typo Co-authored-by: George McCabe <[email protected]> * Update docs/Contributors_Guide/add_use_case.rst Removed end of previously removed sentence. Co-authored-by: George McCabe <[email protected]> Co-authored-by: George McCabe <[email protected]>

…push this change to all the METplus repos.

…ed to all the METplus-related repos.

…of OS

Co-authored-by: George McCabe <[email protected]>

Co-authored-by: johnhg <[email protected]> Co-authored-by: George McCabe <[email protected]>

Co-authored-by: George McCabe <[email protected]>

Testing addition of new default labels

Fixing syntax issue with addition of new default labels

Reverting to original text before changes made for addition of labels.

…flags

Co-authored-by: George McCabe <[email protected]>

* Moved create_release_extra.rst into the release_steps area as all components except for METplus use the same file; Added instructions to update_dtc_website.rst * Removed text that was not supposed to be there. * Update docs/Release_Guide/release_steps/common/update_dtc_website.rst Co-authored-by: johnhg <[email protected]> * Update docs/Release_Guide/release_steps/common/update_dtc_website.rst Co-authored-by: johnhg <[email protected]> * Update docs/Release_Guide/release_steps/common/update_dtc_website.rst Co-authored-by: johnhg <[email protected]> * Removed specific versions of update_dtc_website since they did not differ from the version in release_steps * Added variable - otherWebsiteUpdates - and its value. Co-authored-by: Julie Prestopnik <[email protected]> Co-authored-by: johnhg <[email protected]>

…a release note step about formatting major/important changes in bold.

* Per #1067, modified installation instructions and system configuration to point to installation instructions for MET * removed RTD python package requirements since they are already installed by RTD - fixes issue where bulleted lists bullets disappeared Co-authored-by: Julie Prestopnik <[email protected]> Co-authored-by: George McCabe <[email protected]>

…e update_release_notes files

* removed config variable that is no longer used/needed * cleaned up functions that handle setting CURRENT_[FCST/OBS]_[NAME/LEVEL] * clean up * expand path of config argument to run_metplus.py for easier debugging * removed redundant logic and added comments * cleanup * added logic to move config variables that are runtime specific to a [runtime] section in the final conf that is written after the run completes * changed how config arguments are read so that order that arguments are found is preserved instead of setting explicit overrides at the end * minor change to trigger build, ci-run-all-cases * rearranged logic to save list of config inputs with full paths for easier debugging * move all config vars that start with LOG or end with BASE to runtime section * remove vars that start with CURRENT from final conf * removed confusing logic allowing override of parm base and cleaned up logging to be easier to read/understand * added METPLUS_PARM_BASE env var logic back * added old vs. new default value mismatch info for pb_report_type in PB2NC config file * renamed config var name * use PARM_BASE instead of METPLUS_BASE/parm since it will still be set * use develop version of METviewer docker image (may need to make this configurable in testing.yml in the future) * run cyclone plotter use case to test that new conda environment in docker image now contains missing cartopy map files * added dockerfile to copy cartopy shape files into run image if cartopy is listed as dependencies * download script used to download cartopy shape files and run it * added copy of conda environment * added logic to download cartopy shape files for metplotpy environment * added cartopy dependency to use cases so the shapefiles are copied into run environment * trigger 1 use case that uses metplotpy_env to test cartopy shapefiles are found properly * added instructions to create weatherregime environment that was missing * cleaned up list of packages used * removed extra use case group used for testing * removed netcdf package from env because it is already installed and version number was causing a conflict * added cartopy shapefile copy to use case that needs it * download cartopy shape files for weatherregime python environment because files were not found from base env (metplotpy) * removed debug message that fills up log files with info that is not very useful * updated input directories to use _WeatherRegime directory instead of _Blocking * updated location of input data that was not found in UserScript_fcstGFS_obsERA_WeatherRegime * updated readme with info on how to install metplotpy/metcalcpy in conda environments * added 3rd group of cartopy shapefiles to download because they are used in weatherregime use cases * try using cartopy download script from forked repo that has missing shapefile zip file added * updated input paths to match new data locations

georgemccabe and others added 30 commits March 25, 2021 14:05

removed -ref from end of branch name when looking for new input data …

595a47f

…on web server so develop-ref can check for new develop data

feature 779 add support for output_flag, nc_pairs_flag, and climo_cdf…

3eb23e0

… dictionaries in GridStat (#858)

Feature 779 compare pdf (#860)

6809d8a

Feature 857 tc stat met config (2nd attempt) (#862)

ef813fe

remove quotes around branch items

3972050

only build docs in GHA

f24b9dd

added missing jobs item

d02eef7

cd back to GITHUB_WORKSPACE

ef97e78

cd back to github workspace

e9fce2f

removed html theme options needed for version selector that are no lo…

ed9a553

…nger used

moved documentation building into script, use sphinx_rtd_theme from p…

9e21601

…ip instead of custom version, added info to contrib guide about CI

rename jobs and steps

0e7c5fe

Feature 767 ext dependencies doc update (#866)

2cd8800

Co-authored-by: George McCabe <[email protected]>

feature CI documentation (#867)

2638c4f

Adding NOAA/CPC to the list of requestors. Already ran the script to …

188eab8

…push this change to all the METplus repos.

Adding common label for NOAA/OPC. The new label has already been push…

e5bd13f

…ed to all the METplus-related repos.

sort list of files in directory to ensure the same result regardless …

02ff221

…of OS

Feature 852 series by same name (#868)

4e3827c

Merge branch 'develop-ref' into develop

36fb55e

feature 871 TCGen new MET config variables (#872)

2670308

Feature 728 update python embedding (#876)

0f8f8d3

Co-authored-by: George McCabe <[email protected]>

Merge branch 'develop-ref' into develop

cb5518f

Feature 629 metdbload (#882)

c08f7a2

Co-authored-by: johnhg <[email protected]> Co-authored-by: George McCabe <[email protected]>

feature_630_UIUC_GDF_TDF (#878)

b64b938

Co-authored-by: George McCabe <[email protected]>

moved new use case into another group

cb3504d

Merge branch 'develop-ref' into develop

c46e422

Update MODE_fcstFV3_obsGOES_BrightnessTempObjs.py

2ef4399

feature 880 improve field info handling (#881)

2bf1b02

Feature 686 hdr tdr (#885)

961a170

Co-authored-by: George McCabe <[email protected]>

jprestop and others added 25 commits August 26, 2021 11:51

Update task.md

3b6542e

Testing addition of new default labels

Update task.md

6e9da16

Fixing syntax issue with addition of new default labels

Update task.md

5a1e9ca

Reverting to original text before changes made for addition of labels.

Added additional default labels

6fc94df

Feature 1062 pcp combine level template (#1118)

ef01c02

feature 1069 TCPairs write_valid, valid_inc, valid_exc (#1122)

bba3a9c

Feature 1103 PointStat orank output_flag (#1124)

9309f83

per comment in #1124, changed order of output flags to group related …

35846c4

…flags

Feature 617 gfdl etc (#1121)

758a931

added new use cases to existing use case group

e500623

Merge branch 'develop-ref' into develop

fc1d76e

Feature 1001 blocking statanalysis (#1125)

6805f36

Co-authored-by: George McCabe <[email protected]>

updated instructions for updating the truth dataset reference branch

220b794

Merge branch 'develop-ref' into develop

b7f6f0b

feature_1128_v4.1.0-beta2 (#1129)

881f6ac

update version for development towards next beta release

d35a5ff

updated release guide instructions

e21c498

update instructions to remove references to NCAR/METplus

31e1f43

changed to use PRMSL instead of MSLET for mean sea level pressure

8a64233

Committing directly to develop for a minor documentation change. Add …

00f25e3

…a release note step about formatting major/important changes in bold.

Removing version number from sphinx-gallery and adding one line to th…

20bfaad

…e update_release_notes files

Merge branch 'develop-ref' into develop

0ff21a0

georgemccabe added this to the METplus-4.1.0 milestone Sep 29, 2021

use master branch of SciTools/cartopy since pull request was merged

d7dddb0

georgemccabe merged commit ef19387 into develop-ref Sep 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Develop-ref after #1152 #1181

Update Develop-ref after #1152 #1181

georgemccabe commented Sep 29, 2021

Update Develop-ref after #1152 #1181

Update Develop-ref after #1152 #1181

Conversation

georgemccabe commented Sep 29, 2021

Summary of differences