-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 1392 climo_cdf.direct_prob and SeriesAnalysis #1396
Changes from all commits
13bd4ad
50bb296
c9d6de8
e0be7e0
c416b96
903c544
1c384c2
232cf74
f9fdecb
7676c50
3f54109
fb98504
00622e1
8e1c549
824a3ba
1a62528
5ec42cf
6a624d2
b9e4f8c
8b8accb
fc57e54
332b52f
2d65668
89d3967
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -400,14 +400,6 @@ def get_command(self): | |
cmd += '-outdir {}'.format(self.outdir) | ||
return cmd | ||
|
||
def handle_climo_cdf_dict(self): | ||
self.add_met_config_dict('climo_cdf', { | ||
'cdf_bins': ('float', None, None, | ||
[f'{self.app_name.upper()}_CLIMO_CDF_BINS']), | ||
'center_bins': 'bool', | ||
'write_bins': 'bool', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we have a line for 'direct_prob' here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The red text shows that these lines were removed in the changes. The new version is found in command_builder.py There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ha! Sorry for the confusion! |
||
}) | ||
|
||
def handle_interp_dict(self, uses_field=False): | ||
"""! Reads config variables for interp dictionary, i.e. | ||
_INTERP_VLD_THRESH, _INTERP_SHAPE, _INTERP_METHOD, and | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -129,6 +129,7 @@ GRID_STAT_OUTPUT_PREFIX = {MODEL}_{CURRENT_FCST_NAME}_vs_{OBTYPE}_{CURRENT_OBS_N | |
#GRID_STAT_CLIMO_CDF_BINS = 1 | ||
#GRID_STAT_CLIMO_CDF_CENTER_BINS = False | ||
#GRID_STAT_CLIMO_CDF_WRITE_BINS = True | ||
#GRID_STAT_CLIMO_CDF_DIRECT_PROB = | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we have commented-out defaults listed for all the other CLIMO_CDF options, but no the new DIRECT_PROB one? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should come up with a standard for handling this when we clean up all of the config files. I'm not sure if we have an issue for that, but we would not do that until the next development cycle (5.0.0). When I add support for a new config variables, I put a value so I can test setting the variable to see if it works with the MET app. After testing, I have been removing the value and comment out the variable. When I first added support for these other climo_cdf variables, I was leaving the value so users could see what type of value is expected for these variables. It would be good to be consistent but either way, the purpose of these comments variables are to show examples of all of the config variables that can be used in the basic use case. |
||
|
||
#GRID_STAT_OUTPUT_FLAG_FHO = NONE | ||
GRID_STAT_OUTPUT_FLAG_CTC = STAT | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -103,6 +103,7 @@ POINT_STAT_OUTPUT_FLAG_VL1L2 = STAT | |
#POINT_STAT_CLIMO_CDF_BINS = 1 | ||
#POINT_STAT_CLIMO_CDF_CENTER_BINS = False | ||
#POINT_STAT_CLIMO_CDF_WRITE_BINS = True | ||
#POINT_STAT_CLIMO_CDF_DIRECT_PROB = | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we have commented-out defaults listed for all the other CLIMO_CDF options, but no the new DIRECT_PROB one? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See comment in GridStat.conf |
||
|
||
#POINT_STAT_HSS_EC_VALUE = | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@georgemccabe I did NOT add climo_cdf.direct_prob to the default Ensemble-Stat config file. As the logic exists today, it does not actually APPLY to Ensemble-Stat. But for convenience, I used the same "climo_cdf" setup across all the tools. And work on dtcenter/MET#1602 might make it applicable. I haven't through through all the details yet though.
I recommend leaving this as-is and am not recommending changes. Just wanted to clarify.