Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature #1402 config cleanup model applications #1722

Merged
merged 44 commits into from
Aug 3, 2022
Merged

Feature #1402 config cleanup model applications #1722

merged 44 commits into from
Aug 3, 2022

Commits on Feb 2, 2022

  1. Per #1402, added additional comments to config file including links t… 

    …o documentation. Added old format version of config file that contain many comments with the _DIR/_TEMPLATE variables grouped together for comparison
    @georgemccabe
    georgemccabe committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    4a0afcf View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2022

  1. Merge branch 'develop' into feature_1402_config_cleanup

    @georgemccabe
    georgemccabe committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    0fc46b6 View commit details
    Browse the repository at this point in the history

  2. rearrange variables and added link to user's guide

    @georgemccabe
    georgemccabe committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    7046183 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. updated comment to note that variables in the section are optional

    @georgemccabe
    georgemccabe committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    e9ba518 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. Merge branch 'develop' into feature_1402_config_cleanup

    @georgemccabe
    georgemccabe committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    a31407f View commit details
    Browse the repository at this point in the history

  2. added URL for use case documentation

    @georgemccabe
    georgemccabe committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    b0110a7 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. Merge branch 'develop' into feature_1402_config_cleanup

    @georgemccabe
    georgemccabe committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    cce7b49 View commit details
    Browse the repository at this point in the history

  2. per #1402, rearrange and clean up config file

    @georgemccabe
    georgemccabe committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    6ae90f2 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. added missing config variables from CyclonePlotter to glossary and wr… 

    …appers doc pages
    @georgemccabe
    georgemccabe committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    7b02fe7 View commit details
    Browse the repository at this point in the history

  2. per #1402, clean up use case conf files, ci-run-all-diff

    @georgemccabe
    georgemccabe committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    6c45365 View commit details
    Browse the repository at this point in the history

  3. per #1402, clean up Point2Grid conf file

    @georgemccabe
    georgemccabe committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    2d76352 View commit details
    Browse the repository at this point in the history

  4. per #1402, clean up rest of met_tool_wrapper use case conf files, ci-… 

    …run-all-diff
    @georgemccabe
    georgemccabe committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    551f8c7 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. removed conf file that is no longer needed

    @georgemccabe
    georgemccabe committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    1b0f46b View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. Merge branch 'develop' into feature_1402_config_cleanup

    @georgemccabe
    georgemccabe committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    c024bd7 View commit details
    Browse the repository at this point in the history

  2. per #1402, clean up use cases in air_quality_and_comp, climate, and d… 

    …ata_assimilation
    @georgemccabe
    georgemccabe committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    049fb1c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into feature_1402_config_cleanup_model_app

    @georgemccabe
    georgemccabe committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    f98e178 View commit details
    Browse the repository at this point in the history

  4. per #1402, clean up use cases in marine_and_cryosphere

    @georgemccabe
    georgemccabe committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    c0787cb View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2022

  1. Merge branch 'develop' into feature_1402_config_cleanup_model_app

    @georgemccabe
    georgemccabe committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    0e97a84 View commit details
    Browse the repository at this point in the history

  2. changed URL to use latest instead of develop because even though the … 

    …use case currently is only available in develop, it will eventually be in latest when the next release is created
    @georgemccabe
    georgemccabe committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    2116f06 View commit details
    Browse the repository at this point in the history

  3. per #1402, clean up use case config files for medium_range use cases

    @georgemccabe
    georgemccabe committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    22a2737 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Merge branch 'develop' into feature_1402_config_cleanup_model_app

    @georgemccabe
    georgemccabe committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    84f2f8c View commit details
    Browse the repository at this point in the history

  2. per #1402, rearrange and clean up config files for precipitation use … 

    …cases
    @georgemccabe
    georgemccabe committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    664ec51 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. per #1402, rearrange and clean up config files for s2s, s2s_mid_lat, … 

    …and s2s_mjo. ci-run-all-diff
    @georgemccabe
    georgemccabe committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    ce09848 View commit details
    Browse the repository at this point in the history

  2. fix logic that logs default value used to properly output False vs. e… 

    …mpty string. Previously a False default value was logged as set to empty string
    @georgemccabe
    georgemccabe committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    c0bd80b View commit details
    Browse the repository at this point in the history

  3. fixed logic to not require MTD_SINGLE_RUN to be set for MTD by using … 

    …a default value of False
    @georgemccabe
    georgemccabe committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    05156fd View commit details
    Browse the repository at this point in the history

  4. added wrapped StatAnalysis config file back because the config file f… 

    …or this wrapper is optional and different behavior will be executed if no config file is set
    @georgemccabe
    georgemccabe committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    2787978 View commit details
    Browse the repository at this point in the history

  5. added missing import needed if an error occurs

    @georgemccabe
    georgemccabe committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    ed05775 View commit details
    Browse the repository at this point in the history

  6. added wrapped StatAnalysis config file back because the config file f… 

    …or this wrapper is optional and different behavior will be executed if no config file is set
    @georgemccabe
    georgemccabe committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    1cd974f View commit details
    Browse the repository at this point in the history

  7. run use cases that failed in the last run and ci-run-diff

    @georgemccabe
    georgemccabe committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    d7f7cb8 View commit details
    Browse the repository at this point in the history

  8. fixed path that used CONFIG_DIR because variable was removed

    @georgemccabe
    georgemccabe committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    ef6f3a6 View commit details
    Browse the repository at this point in the history

  9. turn off use cases that passed to test again

    @georgemccabe
    georgemccabe committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    ccfa89a View commit details
    Browse the repository at this point in the history

  10. per #1402, rearrange and clean up config files for short_range use cases

    @georgemccabe
    georgemccabe committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    4e2c002 View commit details
    Browse the repository at this point in the history

  11. per #1402, rearrange and clean up space_weather config files

    @georgemccabe
    georgemccabe committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    da4e01b View commit details
    Browse the repository at this point in the history

  12. per #1402, updated another use case conf

    @georgemccabe
    georgemccabe committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    c5b2a9a View commit details
    Browse the repository at this point in the history

  13. add support for setting match_points in the TCPairs wrapped config fi… 

    …le and replace MET_CONFIG_OVERRIDE variable with TC_PAIRS_MATCH_POINTS
    @georgemccabe
    georgemccabe committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    dcc8028 View commit details
    Browse the repository at this point in the history

  14. per #1402, rearrange and clean up config files for tc_and_extra_tc us… 

    …e cases. ci-run-all-diff
    @georgemccabe
    georgemccabe committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    40ee888 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2022

  1. Merge branch 'develop' into feature_1402_config_cleanup_model_app

    @georgemccabe
    georgemccabe committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    6ad33e7 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. turn off use cases

    @georgemccabe
    georgemccabe committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    dd5c2eb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature_1402_config_cleanup_model_app

    @georgemccabe
    georgemccabe committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    367d111 View commit details
    Browse the repository at this point in the history

  3. if TC_PAIRS_MATCH_POINTS is unset, set 'match_points = TRUE;'. This i… 

    …s done because the value in the TCPairsConfig_wrapped file was TRUE, but the default value in the MET config file is FALSE. Typically if a METplus variable is unset, we do not set any value for the corresponding env var which results in using the value in the default MET config file. Doing this would cause many use cases to change their results unless TC_PAIRS_MATCH_POINTS=True was added to each use case config file. We could do this for our repository, but any use case config files outside of the METplus repo would need to be updated
    @georgemccabe
    georgemccabe committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    a4f4af4 View commit details
    Browse the repository at this point in the history

  4. fixed TCPairs unit tests to handle default value for match_points

    @georgemccabe
    georgemccabe committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    6471b51 View commit details
    Browse the repository at this point in the history

  5. added variables that are needed for use case and were accidentally re… 

    …moved
    @georgemccabe
    georgemccabe committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    a41115f View commit details
    Browse the repository at this point in the history

  6. log error and increment error count if required lat/lon bound variabl… 

    …es are not set instad of calling sys.exit
    @georgemccabe
    georgemccabe committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    4d318db View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2022

  1. skip metplus_final.conf in check for new output to prevent false alar… 

    …m diffs
    @georgemccabe
    georgemccabe committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    748c098 View commit details
    Browse the repository at this point in the history