Added a --files option to analyse rustc's --emit=llvm-lines output. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
reviewed
Oct 3, 2020
Comment on lines
+54
to
+55
| /// Analyze .ll files that were produced by eg. `RUSTFLAGS="--emit=llvm-ir" ./x.py build --stage 0 compiler/rustc`. | ||
| /// Supports globs, eg `./build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/debug/deps/*.ll` |
There was a problem hiding this comment.
This is probably a little more complicated of an example than you need to give in public docs. It's better suited for rustc-dev-guide IMO.
Suggested change
| /// Analyze .ll files that were produced by eg. `RUSTFLAGS="--emit=llvm-ir" ./x.py build --stage 0 compiler/rustc`. | |
| /// Supports globs, eg `./build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/debug/deps/*.ll` | |
| /// Analyze .ll files produced by `RUSTFLAGS="--emit=llvm-ir"`. | |
| /// | |
| /// Supports globs, e.g. `./build/debug/deps/*.ll` |
| @@ -50,6 +51,17 @@ enum Opt { | |||
| )] | |||
| sort: SortOrder, | |||
|
|
|||
| /// Analyze .ll files that were produced by eg. `RUSTFLAGS="--emit=llvm-ir" ./x.py build --stage 0 compiler/rustc`. | |||
| /// Supports globs, eg `./build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/debug/deps/*.ll` | |||
| // zsh substitutes the glob with a list of files, therefore this needs to be a Vec. | |||
There was a problem hiding this comment.
Is there a reason to both support globs and multiple files? It seems easier to let the shell expand the glob instead (and means less dependencies for llvm-lines).
There was a problem hiding this comment.
Changed in #33 to leave globbing to the shell.
| @@ -50,6 +51,17 @@ enum Opt { | |||
| )] | |||
| sort: SortOrder, | |||
|
|
|||
| /// Analyze .ll files that were produced by eg. `RUSTFLAGS="--emit=llvm-ir" ./x.py build --stage 0 compiler/rustc`. | |||
There was a problem hiding this comment.
This should mention that it ignores files that don't end in .ll, I would not expect that behavior. Maybe it shouldn't ignore them?
There was a problem hiding this comment.
Changed in #33 to not ignore any files.
|
Thanks for addressing the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since you can't use cargo-llvm-lines with x.py, I added a
--filesoption, so that I could measure the llvm-lines of rustc itself.I'm also writing an entry in rustc-dev-guide. Example usage:
I successfully used this in rust-lang/rust#76680.