Derive Eq for VersionReq
#109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to make sense to me. `Version` already implements it.
|
That said, maybe EDIT: Another approach seems more sensible for binary-only deps. |
Mostly, "I haven't thought about it enough", especially EQ. Are these actually total? I'm not sure. |
|
Why shouldn't it be reflexive? Maybe I'm missing something, but I think |
|
I'm not saying it's not, I'm saying "this is a guarantee and I have given literally zero thought as to how it's true, especially when you bring in stuff like the prerelease rules, etc." |
|
Closing, this ain't going nowhere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to make sense to me.
Versionalready implements it.