Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timedelta verification to merge_double_ended_times #175

Merged
merged 7 commits into from
Jul 27, 2023

Conversation

bdestombe
Copy link
Collaborator

…le ended to double ended

@BSchilperoort
Copy link
Collaborator

BSchilperoort commented Jul 21, 2023

"Add timedelta verification to merge_double_ended_times"? 😅

If you change the PR title to that and do "squash and merge" when merging the PR you can make the commit message on the main branch fit the max. line length

@bdestombe bdestombe changed the title Also verify timedeltas between forward and backward when merging sing… Add timedelta verification to merge_double_ended_times Jul 21, 2023
Copy link
Collaborator

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you managed to implement this verification :)

Just some small comments from me

src/dtscalibration/datastore_utils.py Outdated Show resolved Hide resolved
src/dtscalibration/datastore_utils.py Outdated Show resolved Hide resolved
src/dtscalibration/datastore_utils.py Show resolved Hide resolved
src/dtscalibration/datastore_utils.py Outdated Show resolved Hide resolved
@BSchilperoort
Copy link
Collaborator

Oh and don't forget to update the changelog!

@bdestombe bdestombe merged commit a6b374d into main Jul 27, 2023
11 checks passed
@bdestombe bdestombe deleted the merge-single-ended-to-double-check-dt branch July 27, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants