Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Move website build chain to ESM #4649

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

👷 Move website build chain to ESM #4649

wants to merge 2 commits into from

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jan 22, 2024

Category:

  • ✨ Introduce new features
  • 📝 Add or update documentation
  • ✅ Add or update tests
  • 🐛 Fix a bug
  • 🏷️ Add or update types
  • ⚡️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

Copy link

codesandbox-ci bot commented Jan 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 21242ca:

Sandbox Source
@fast-check/examples Configuration

@dubzzz
Copy link
Owner Author

dubzzz commented Jan 22, 2024

Failing at Run yarn workspace website build with:

[INFO] [en] Creating an optimized production build...
[info] [webpackbar] Compiling Client
[info] [webpackbar] Compiling Server
[success] [webpackbar] Client: Compiled successfully in 23.58s
[success] [webpackbar] Server: Compiled with some errors in 25.16s

Error: Unable to build website for locale en.

    at tryToBuildLocale (/home/runner/work/fast-check/fast-check/.yarn/__virtual__/@docusaurus-core-virtual-1a479300b6/4/.yarn/berry/cache/@docusaurus-core-npm-3.1.0-e2c1849322-10c0.zip/node_modules/@docusaurus/core/lib/commands/build.js:55:19)
[INFO] Docusaurus version: 3.1.0
Node version: v20.11.0
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async mapAsyncSequential (/home/runner/work/fast-check/fast-check/.yarn/__virtual__/@docusaurus-utils-virtual-462f6e933a/4/.yarn/berry/cache/@docusaurus-utils-npm-3.1.0-987dffbfde-10c0.zip/node_modules/@docusaurus/utils/lib/jsUtils.js:44:24)
    at async Command.build (/home/runner/work/fast-check/fast-check/.yarn/__virtual__/@docusaurus-core-virtual-1a479300b6/4/.yarn/berry/cache/@docusaurus-core-npm-3.1.0-e2c1849322-10c0.zip/node_modules/@docusaurus/core/lib/commands/build.js:82:21) {
  [cause]: Error: Failed to compile due to Webpack errors.
  TypeError: require.resolveWeak is not a function
      at /home/runner/work/fast-check/fast-check/.yarn/__virtual__/@docusaurus-core-virtual-1a479300b6/4/.yarn/berry/cache/@docusaurus-core-npm-3.1.0-e2c1849322-10c0.zip/node_modules/@docusaurus/core/lib/webpack/utils.js:207:24
      at /home/runner/work/fast-check/fast-check/.yarn/__virtual__/webpack-virtual-056dc0b43c/4/.yarn/berry/cache/webpack-npm-5.89.0-3800e9efd0-10c0.zip/node_modules/webpack/lib/MultiCompiler.js:554:14
      at processQueueWorker (/home/runner/work/fast-check/fast-check/.yarn/__virtual__/webpack-virtual-056dc0b43c/4/.yarn/berry/cache/webpack-npm-5.89.0-3800e9efd0-10c0.zip/node_modules/webpack/lib/MultiCompiler.js:491:6)
      at process.processTicksAndRejections (node:internal/process/task_queues:77:11)

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.57%. Comparing base (879831c) to head (21242ca).
Report is 219 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4649   +/-   ##
=======================================
  Coverage   93.57%   93.57%           
=======================================
  Files         207      207           
  Lines        5011     5011           
  Branches     1367     1367           
=======================================
  Hits         4689     4689           
  Misses        322      322           
Flag Coverage Δ
unit-tests 93.57% <ø> (ø)
unit-tests-18.x-Linux 93.57% <ø> (ø)
unit-tests-20.x-Linux 93.57% <ø> (ø)
unit-tests-latest-Linux ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz
Copy link
Owner Author

dubzzz commented Jan 30, 2024

The issue seems similar to the one detailed at facebook/docusaurus#6520 (comment)

Copy link

stale bot commented Apr 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 22, 2024
@dubzzz dubzzz removed the stale label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant