Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-FLAG variants of flags #86

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Conversation

blyxxyz
Copy link
Collaborator

@blyxxyz blyxxyz commented Mar 3, 2021

Resolves #84.

I found a way of doing this that's fairly low on manual maintenance.

I noticed the man page includes the version number and the month, so generate.sh should be run for each release after editing Cargo.toml. (Maybe it's time for a checklist?)

@blyxxyz blyxxyz marked this pull request as draft March 4, 2021 00:36
@ducaale
Copy link
Owner

ducaale commented Mar 4, 2021

Maybe it's time for a checklist?

I agree 😅. These are the steps I usually do now:

  • Update CHANGELOG.md (rename unreleased header to the current date, add any missing changes)
  • Bump up the version in Cargo.toml and run cargo check to update Cargo.lock
  • commit changes and push them to remote.
  • Add git tag i.e git tag v0.9.0
  • Push the local tags to remote i.e git push --tags which will start the CI release action.
  • publish to crates.io i.e cargo publish

@blyxxyz blyxxyz marked this pull request as ready for review March 4, 2021 19:23
Copy link
Owner

@ducaale ducaale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ducaale ducaale merged commit e81e896 into ducaale:develop Mar 4, 2021
@blyxxyz blyxxyz deleted the negating-flags branch March 4, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants