Simplify extension loading in dbt-duckdb #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #179
In the old code, we would re-load any DuckDB extensions that we needed for the config in the connection that we used for each dbt thread. This was generally fine in that loading an already-loaded DuckDB extension is idempotent-- except when it wasn't, due to some sort of bug (as in #179).
The good news though is that this extension reloading is unnecessary now, and since we're pinning ourselves to post 0.5.0 versions of DuckDB, we can also switch to using the more python
install_extensionandload_extensionmethods on the DuckDB connection in order to load the extensions once per run, instead of on each thread.