libduckdb-sys: include duckdb (1.1.1) as a submodule #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Build it directly with cmake, having a cargo feature for each extension. - parquet is documented as being required, so the extension is always enabled and the feature is ignored (for backwards compatibility) - the "delta" extension doesn't build, so there's no feature for it
njaard
force-pushed
the
libduck-submodule
branch
from
309556d
to
75c42e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the way libduckdb is built. Because I don't have Windows, I can't verify it works there.
Most importantly, it brings libduckdb up to the most recent version so that there can be extensions like spatial and so on.
I regenerated the bindings, but the diff was empty.
I didn't want libduckdb's jemalloc to conflict with rust's
jemalloc-sys, so I disabled that extension. It should be documented that you should use the cratejemallocatorwith this crate.