Upgrade to duckdb 1.1.3 #399
Open
+1,151
−371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upgrade script was missing crates/duckdb/Cargo.toml in its sed command, causing a unit test to fail.
|
I'm a little confused about the intent of the failing test. The panic says "expected error" but I'm wondering if thats a typo and its actually an unexpected error? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I am hacking on a project using duckdb rust and noticed that the duckdb version was slightly out of date.
This came to my attention because it seems like a community plugin I am trying to use does not have updated binaries for duckdb 1.1.1 (the bigquery extension, to be specific).
Also, the upgrade script I think was missing
crates/duckdb/Cargo.toml, so I added that in.