[Arrow] Support consuming an "arrow_array_stream" PyCapsule #13386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… still valid before initiating the scan
pdet
suggested changes
Aug 12, 2024
| table_function.function = make_uniq<FunctionExpression>("arrow_scan", std::move(children)); | ||
| if (type == PyArrowObjectType::PyCapsule) { | ||
| // Disable projection+filter pushdown | ||
| table_function.function = make_uniq<FunctionExpression>("arrow_scan_dumb", std::move(children)); |
There was a problem hiding this comment.
"arrow_scan_dumb" already exists, I believe we can enable projection pushdown, but I didn't want to add the overhead of testing that, that sounds more like a future optimization if this functionality becomes popular/used a lot
There was a problem hiding this comment.
I think I've seen it, it still is not a great name name since it conveys very little of the difference between a regular arrow_scan and a "dumb" one.
There was a problem hiding this comment.
Hmm I agree, but it's used by duckdb-java, see the initial PR and the JDBC Client source code
I'm hesitant to rename something that's used by third party clients
…le interface without pyarrow
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Aug 13, 2024
Merge pull request duckdb/duckdb#13383 from Tmonster/fix_vector_sizes_nightly_failure Merge pull request duckdb/duckdb#13386 from Tishj/pycapsule_test
Open
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #10716
This allows consuming arrow array streams from PyCapsules, which do not necessarily have to be created by
pyarrow.For regular arrow scans we use
pyarrowto perform filter pushdown on the stream, constructing a scanner to do so.When scanning from a PyCapsule we disable this so no interaction with
pyarrowis required.