Cleanup workflow

.github/workflows/Rest.yml

@@ -1,5 +1,5 @@
 name: Rest
-on: [push, pull_request, repository_dispatch]
+on: [pull_request, repository_dispatch]
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}-${{ github.head_ref || '' }}-${{ github.base_ref || '' }}-${{ github.ref != 'refs/heads/main' || github.sha }}
   cancel-in-progress: true
@@ -11,88 +11,54 @@ jobs:
   rest:
     name: Test against Rest Catalog
     runs-on: ubuntu-latest
-    container: ${{ matrix.container }}
-    strategy:
-      matrix:
-        # Add commits/tags to build against other DuckDB versions
-        duckdb_version: [ '<submodule_version>' ]
-        arch: ['linux_amd64', 'linux_arm64', 'linux_amd64_gcc4']
-        vcpkg_version: [ '2023.04.15' ]
-        include:
-          - arch: 'linux_amd64_gcc4'
-            container: 'quay.io/pypa/manylinux2014_x86_64'
-            vcpkg_triplet: 'x64-linux'
-          - arch: 'linux_amd64'
-            container: 'ubuntu:18.04'
-            vcpkg_triplet: 'x64-linux'
-          - arch: 'linux_arm64'
-            container: 'ubuntu:18.04'
-            vcpkg_triplet: 'arm64-linux'
     env:
-      VCPKG_TARGET_TRIPLET: ${{ matrix.vcpkg_triplet }}
+      VCPKG_TARGET_TRIPLET: 'x64-linux'
       GEN: Ninja
       VCPKG_TOOLCHAIN_PATH: ${{ github.workspace }}/vcpkg/scripts/buildsystems/vcpkg.cmake
 
     steps:
       - name: Install required ubuntu packages
-        if: ${{ matrix.arch == 'linux_amd64' || matrix.arch == 'linux_arm64' }}
         run: |
-          apt-get update -y -qq
-          apt-get install -y -qq software-properties-common
-          add-apt-repository ppa:git-core/ppa
-          apt-get update -y -qq
-          apt-get install -y -qq ninja-build make gcc-multilib g++-multilib libssl-dev wget openjdk-8-jdk zip maven unixodbc-dev libc6-dev-i386 lib32readline6-dev libssl-dev libcurl4-gnutls-dev libexpat1-dev gettext unzip build-essential checkinstall libffi-dev curl libz-dev openssh-client
-          apt-get install -y -qq tar pkg-config
+          sudo apt-get update -y -qq
+          sudo apt-get install -y -qq software-properties-common
+          sudo add-apt-repository ppa:git-core/ppa
+          sudo apt-get update -y -qq
+          sudo apt-get install -y -qq ninja-build make gcc-multilib g++-multilib libssl-dev wget openjdk-8-jdk zip maven unixodbc-dev libc6-dev-i386 lib32readline6-dev libssl-dev libcurl4-gnutls-dev libexpat1-dev gettext unzip build-essential checkinstall libffi-dev curl libz-dev openssh-client
+          sudo apt-get install -y -qq tar pkg-config
+          sudo curl -L "https://github.com/docker/compose/releases/download/1.29.2/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose
+          sudo chmod +x /usr/local/bin/docker-compose
 
       - name: Install Git 2.18.5
-        if: ${{ matrix.arch == 'linux_amd64' || matrix.arch == 'linux_arm64' }}
         run: |
           wget https://github.com/git/git/archive/refs/tags/v2.18.5.tar.gz
           tar xvf v2.18.5.tar.gz
           cd git-2.18.5
           make
-          make prefix=/usr install
+          sudo make prefix=/usr install
           git --version
 
       - uses: actions/checkout@v3
         with:
           fetch-depth: 0
           submodules: 'true'
 
-      - name: Checkout DuckDB to version
-        if: ${{ matrix.duckdb_version != '<submodule_version>'}}
-        run: |
-          cd duckdb
-          git checkout ${{ matrix.duckdb_version }}
-
       - name: Setup ManyLinux2014
-        if: ${{ matrix.arch == 'linux_amd64_gcc4' }}
         run: |
           ./duckdb/scripts/setup_manylinux2014.sh general aws-cli ccache ssh openssl python_alias
 
-      - name: Setup Ubuntu
-        if: ${{ matrix.arch == 'linux_amd64' || matrix.arch == 'linux_arm64' }}
-        uses: ./duckdb/.github/actions/ubuntu_18_setup
-        with:
-          aarch64_cross_compile: 1
-
       - name: Setup vcpkg
         uses: lukka/[email protected]
         with:
           vcpkgGitCommitId: 501db0f17ef6df184fcdbfbe0f87cde2313b6ab1
 
-      # Build extension
       - name: Build extension
         env:
           GEN: ninja
           STATIC_LIBCPP: 1
-          CC: ${{ matrix.arch == 'linux_arm64' && 'aarch64-linux-gnu-gcc' || '' }}
-          CXX: ${{ matrix.arch == 'linux_arm64' && 'aarch64-linux-gnu-g++' || '' }}
         run: |
           make release
 
       - name: Start Rest Catalog
-        if: ${{ matrix.arch == 'linux_amd64_gcc4' || matrix.arch == 'linux_amd64' }}
         working-directory: scripts/
         run: |
           ./start-rest-catalog.sh

.gitignore

@@ -10,3 +10,4 @@ test/sql/tmp.test
 data/iceberg/generated_*
 scripts/metastore_db/
 scripts/derby.log
+scripts/test-script-with-path.sql

scripts/provision.py

@@ -34,10 +34,10 @@
     )
     .config("spark.sql.catalog.demo", "org.apache.iceberg.spark.SparkCatalog")
     .config("spark.sql.catalog.demo.type", "rest")
-    .config("spark.sql.catalog.demo.uri", "http://localhost:8181")
+    .config("spark.sql.catalog.demo.uri", "http://127.0.0.1:8181")
     .config("spark.sql.catalog.demo.io-impl", "org.apache.iceberg.aws.s3.S3FileIO")
     .config("spark.sql.catalog.demo.warehouse", "s3://warehouse/wh/")
-    .config("spark.sql.catalog.demo.s3.endpoint", "http://localhost:9000")
+    .config("spark.sql.catalog.demo.s3.endpoint", "http://127.0.0.1:9000")
     .config("spark.sql.catalog.demo.s3.path-style-access", "true")
     .config("spark.sql.defaultCatalog", "demo")
     .config("spark.sql.catalogImplementation", "in-memory")

scripts/start-rest-catalog.sh

@@ -19,13 +19,19 @@ LOAD iceberg;
 
 SET s3_access_key_id='admin';
 SET s3_secret_access_key='password';
-SET s3_endpoint='localhost:9000';
+SET s3_endpoint='127.0.0.1:9000';
 SET s3_url_style='path';
 SET s3_use_ssl=false;
 
-SELECT * FROM iceberg_scan('${UNPARTITIONED_TABLE_PATH}')
+SELECT * FROM iceberg_scan('${UNPARTITIONED_TABLE_PATH}');
 END
 
 )
 
-duckdb -s $SQL
+if test -f "../build/release/duckdb"
+then
+  # in CI
+  ../build/release/duckdb -s "$SQL"
+else
+  duckdb -s "$SQL"
+fi