small cleanup

duckdb · Oct 6, 2023 · fd8f7d2 · fd8f7d2
1 parent 768e785
commit fd8f7d2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/README.md b/README.md
@@ -32,7 +32,7 @@ based on pyspark 3.4, which you can install through pip.
 To build the extension with vcpkg, you can build this extension using:
 
 ```shell
-VCPKG_TOOLCHAIN_PATH='<path_to_your_vcpkg_toolchain>' make
+VCPKG_TOOLCHAIN_PATH='<path_to_your_vcpkg_toolchain_cmake_file>' make
 ```
 
 This will build both the separate loadable extension and a duckdb binary with the extension pre-loaded:

diff --git a/src/iceberg_functions/iceberg_scan.cpp b/src/iceberg_functions/iceberg_scan.cpp
@@ -223,29 +223,24 @@ static unique_ptr<TableRef> IcebergScanBindReplace(ClientContext &context, Table
 	}
 }
 
-static unique_ptr<FunctionData> IcebergScanBind(ClientContext &context, TableFunctionBindInput &input,
-                                                vector<LogicalType> &return_types, vector<string> &names) {
-	return nullptr;
-}
-
 TableFunctionSet IcebergFunctions::GetIcebergScanFunction() {
 	TableFunctionSet function_set("iceberg_scan");
 
 	auto fun =
-	    TableFunction({LogicalType::VARCHAR}, nullptr, IcebergScanBind, IcebergScanGlobalTableFunctionState::Init);
+	    TableFunction({LogicalType::VARCHAR}, nullptr, nullptr, IcebergScanGlobalTableFunctionState::Init);
 	fun.bind_replace = IcebergScanBindReplace;
 	fun.named_parameters["allow_moved_paths"] = LogicalType::BOOLEAN;
 	fun.named_parameters["mode"] = LogicalType::VARCHAR;
 	function_set.AddFunction(fun);
 
-	fun = TableFunction({LogicalType::VARCHAR, LogicalType::UBIGINT}, nullptr, IcebergScanBind,
+	fun = TableFunction({LogicalType::VARCHAR, LogicalType::UBIGINT}, nullptr, nullptr,
 	                    IcebergScanGlobalTableFunctionState::Init);
 	fun.bind_replace = IcebergScanBindReplace;
 	fun.named_parameters["allow_moved_paths"] = LogicalType::BOOLEAN;
 	fun.named_parameters["mode"] = LogicalType::VARCHAR;
 	function_set.AddFunction(fun);
 
-	fun = TableFunction({LogicalType::VARCHAR, LogicalType::TIMESTAMP}, nullptr, IcebergScanBind,
+	fun = TableFunction({LogicalType::VARCHAR, LogicalType::TIMESTAMP}, nullptr, nullptr,
 	                    IcebergScanGlobalTableFunctionState::Init);
 	fun.bind_replace = IcebergScanBindReplace;
 	fun.named_parameters["allow_moved_paths"] = LogicalType::BOOLEAN;