Change yyjson_get_tag() to yyjson_get_type() when doing type comparisons. #50
+12,165
−8,384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many comparisons where performed using `yyjson_get_tag()` rather than `yyjson_get_type()`. The tag can have additional information set using bits beyond just the type, causing these type comparisons to fail and JSON failing to parse. fix: fix the extension to build with current duckdb main branch. Fix a few std::move() calls and a call to fs.OpenFile().
This was referenced Apr 10, 2024
|
Issue #39 is fixed with this PR |
|
Looks good to me, thanks a lot! |
carlopi
added a commit
to carlopi/duckdb
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: change yyjson comparisions to type rather than tag.
Many comparisons were performed using
yyjson_get_tag()rather thanyyjson_get_type(). The tag can have additional information set using bits beyond just the type, causing these type comparisons to fail and parsing the metadata to fail.fix: fix the extension to build with current duckdb main branch.
Fix a few
std::move()calls and a call tofs.OpenFile().