Skip to content

Commit

Permalink
Pass version and app_identifier to increment_build_number
Browse files Browse the repository at this point in the history
  • Loading branch information
graeme committed Sep 8, 2023
1 parent 509a6cd commit 29790c4
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/alpha.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
run: |
app_version="$(cut -d ' ' -f 3 < Configuration/Version.xcconfig)"
bundle exec fastlane increment_build_number_for_version:app_version
bundle exec fastlane increment_build_number_for_version version:app_version app_identifier:"com.duckduckgo.mobile.ios.alpha"
bundle exec fastlane release_alpha groups:"${{ steps.destination.outputs.destination }}"
build_version="cat DuckDuckGo.xcodeproj/project.pbxproj | grep -m1 'CURRENT_PROJ ECT_VERSION' | cut -d'=' -f2 | tr -d ';' | tr -d ' '"
echo "dsyms_path=${{ github.workspace }}/DuckDuckGo.app.dSYM.zip" >> $GITHUB_ENV
Expand Down
8 changes: 6 additions & 2 deletions fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ lane :upload_metadata do |options|
end

desc 'Makes App Store release build and uploads it to TestFlight'
lane :release_testflight do
lane :release_beta do
build_release

upload_to_testflight(
Expand All @@ -140,11 +140,15 @@ end

desc 'Increment build number based on version in App Store Connect'
lane :increment_build_number_for_version do |options|
app_identifier = "com.duckduckgo.mobile.ios"
if options[:app_identifier]
app_identifier = options[:app_identifier]
end
increment_build_number({
build_number:
latest_testflight_build_number(
version: options[:version],
app_identifier: "com.duckduckgo.mobile.ios",
app_identifier: app_identifier,
initial_build_number: -1,
username: get_username(options)) + 1,
skip_info_plist: "true"
Expand Down

0 comments on commit 29790c4

Please sign in to comment.