Skip to content

Commit

Permalink
Fix Localizable strings
Browse files Browse the repository at this point in the history
  • Loading branch information
alessandroboron committed Sep 10, 2024
1 parent fbeb95b commit ce1f0ae
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 4 deletions.
7 changes: 4 additions & 3 deletions DuckDuckGo/UserText.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1365,10 +1365,10 @@ But if you *do* want a peek under the hood, you can find more information about
}

enum BrowsersComparison {
public static let title = NSLocalizedString("onboarding.browsers.title", value: "Protections activated!", comment: "The title of the dialog to show the privacy features that DuckDuckGo offers")
public static let title = NSLocalizedString("onboarding.highlights.browsers.title", value: "Protections activated!", comment: "The title of the dialog to show the privacy features that DuckDuckGo offers")

enum Features {
public static let trackerBlockers = NSLocalizedString("onboarding.browsers.features.trackerBlocker.title", value: "Block 3rd party trackers", comment: "Message to highlight browser capability ofblocking 3rd party trackers")
public static let trackerBlockers = NSLocalizedString("onboarding.highlights.browsers.features.trackerBlocker.title", value: "Block 3rd party trackers", comment: "Message to highlight browser capability ofblocking 3rd party trackers")
public static let cookiePopups = NSLocalizedString("onboarding.highlights.browsers.features.cookiePopups.title", value: "Block cookie requests & popups", comment: "Message to highlight how the browser allows you to block cookie pop-ups")
public static let creepyAds = NSLocalizedString("onboarding.highlights.browsers.features.creepyAds.title", value: "Block targeted ads", comment: "Message to highlight browser capability of blocking creepy ads")
public static let eraseBrowsingData = NSLocalizedString("onboarding.highlights.browsers.features.eraseBrowsingData.title", value: "Erase browsing data swiftly", comment: "Message to highlight browser capability of swiftly erase browsing data")
Expand All @@ -1383,7 +1383,8 @@ But if you *do* want a peek under the hood, you can find more information about

enum AddressBarPosition {
public static let title = NSLocalizedString("onboarding.highlights.addressBarPosition.title", value: "Where should I put your address bar?", comment: "The title of the onboarding dialog popup to select the preferred address bar position.")
public static let topTitle = NSLocalizedString("onboarding.highlights.addressBarPosition.top.title", value: "Top (Default)", comment: "The title of the option to set the address bar to the top.")
public static let topTitle = NSLocalizedString("onboarding.highlights.addressBarPosition.top.title", value: "Top", comment: "The title of the option to set the address bar to the top.")
public static let defaultOption = NSLocalizedString("onboarding.highlights.addressBarPosition.default", value: "(Default)", comment: "Indicates what address bar option (Top/Bottom) is the default one. E.g. Top (Default)")
public static let topMessage = NSLocalizedString("onboarding.highlights.addressBarPosition.top.message", value: "Easy to see", comment: "The message of the option to set the address bar to the top.")
public static let bottomTitle = NSLocalizedString("onboarding.highlights.addressBarPosition.bottom.title", value: "Bottom", comment: "The title of the option to set the address bar to the bottom.")
public static let bottomMessage = NSLocalizedString("onboarding.highlights.addressBarPosition.bottom.message", value: "Easy to reach", comment: "The message of the option to set the address bar to the bottom.")
Expand Down
11 changes: 10 additions & 1 deletion DuckDuckGo/en.lproj/Localizable.strings
Original file line number Diff line number Diff line change
Expand Up @@ -1847,14 +1847,17 @@ https://duckduckgo.com/mac";
/* The title of the CTA to progress to the next onboarding screen. */
"onboarding.highlights.addressBarPosition.cta" = "Next";

/* Indicates what address bar option (Top/Bottom) is the default one. E.g. Top (Default) */
"onboarding.highlights.addressBarPosition.default" = "(Default)";

/* The title of the onboarding dialog popup to select the preferred address bar position. */
"onboarding.highlights.addressBarPosition.title" = "Where should I put your address bar?";

/* The message of the option to set the address bar to the top. */
"onboarding.highlights.addressBarPosition.top.message" = "Easy to see";

/* The title of the option to set the address bar to the top. */
"onboarding.highlights.addressBarPosition.top.title" = "Top (Default)";
"onboarding.highlights.addressBarPosition.top.title" = "Top";

/* The title of the CTA to progress to the next onboarding screen. */
"onboarding.highlights.appIconSelection.cta" = "Next";
Expand All @@ -1874,6 +1877,12 @@ https://duckduckgo.com/mac";
/* Message to highlight browser capability of swiftly erase browsing data */
"onboarding.highlights.browsers.features.eraseBrowsingData.title" = "Erase browsing data swiftly";

/* Message to highlight browser capability ofblocking 3rd party trackers */
"onboarding.highlights.browsers.features.trackerBlocker.title" = "Block 3rd party trackers";

/* The title of the dialog to show the privacy features that DuckDuckGo offers */
"onboarding.highlights.browsers.title" = "Protections activated!";

/* The title of the fire button CTA to skip erasing the data. */
"onboarding.highlights.fireDialog.cta.skip" = "Skip";

Expand Down

0 comments on commit ce1f0ae

Please sign in to comment.