fix ui tests broken by new onboarding and use shared setup flow #3081
Conversation
github-actions
bot
added
the
bot: not in app board
brindy
removed
the
bot: not in app board
Core/DefaultVariantManager.swift
Outdated
| @@ -91,7 +91,7 @@ public protocol VariantRNG { | |||
| public class DefaultVariantManager: VariantManager { | |||
|
|
|||
| public var currentVariant: Variant? { | |||
| let variantName = ProcessInfo.processInfo.environment["VARIANT", default: storage.variant ?? "" ] | |||
There was a problem hiding this comment.
Out of curiosity, how come we changed from environment variable to launch argument?
Maestro lets set you the env variable as per Maestro doc
There was a problem hiding this comment.
Ah, I just didn't know. This is even better. Will revert to the env version
There was a problem hiding this comment.
OK, had a look at this.
1/ Env doesn't appear to actually work. I added some extra UI in the debug screen to check it (haven't committed that).
2/ We'd have to put it in every file since env is specific to the flow and I'm trying to have a standard 'set up' flow.
Interestingly the VARIANT argument gets changed to -VARIANT for some reason. Tested this with autoclear and that argument doesn't, but maybe because it's a bool?
Anyway, specifying an override prevents dax dialogs from showing and I think we want that because we want these tests to run against a something as close to production as possible. So I am going to change the tests to just get past the onboarding and do everything else as expected.
Once we look to merge the new dax dialogs we'll have to update the tests again.
There was a problem hiding this comment.
Ah bummer, I saw that it was available so I suggested it. Thanks for the explanation, makes sense.
|
Hey Brindy: When I tested manually I got the expected behaviour. When I run the test in some instance I got into this scenario. The launch argument variant is “ru” but the onboarding shown is the new one. 
|
# By Mariusz Śpiewak (2) and others # Via GitHub * main: Remove print (#3101) Update Package.resolved file (#3102) New Tab Page favorites section (#3083) Properly compare actual value of the entitlement check (#3100) fix ui tests broken by new onboarding and use shared setup flow (#3081) # Conflicts: # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
* main: Bump submodules/privacy-reference-tests from `a242bf0` to `afb4f61` (#3096) Updates BSK to 171.2.3 Remove print (#3101) Update Package.resolved file (#3102) New Tab Page favorites section (#3083) Properly compare actual value of the entitlement check (#3100) fix ui tests broken by new onboarding and use shared setup flow (#3081)
# By Christopher Brind (9) and others # Via Chris Brind (1) and GitHub (1) * main: (48 commits) Reduce VPN manager instances (#3097) Update BSK for Mac RMF changes (#3107) [DuckPlayer] 7- Open Settings (#3110) [DuckPlayer] 6 - Init updates and Watch on YouTube (#3066) New Tab Page Shortcuts section (#3104) Fix VPN configuration removal to stop the tunnel (#3099) avoid resizing webview when keyboard shows/hides (#3094) Add support for skipping sending usage pixels for remote messages (#3106) Bump submodules/privacy-reference-tests from `a242bf0` to `afb4f61` (#3096) Updates BSK to 171.2.3 Remove print (#3101) Update Package.resolved file (#3102) New Tab Page favorites section (#3083) Properly compare actual value of the entitlement check (#3100) fix ui tests broken by new onboarding and use shared setup flow (#3081) AdHoc lane: Make proper assignment to variable (#3095) Expand AdHoc build workflow, add debug bookmarks screen (#3086) Update BSK to latest - for macOS fix to AdAttribution (#3084) Revert "Fix tests" Fix tests ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/NetworkProtectionStatusViewModel.swift
Task/Issue URL: https://app.asana.com/0/392891325557410/1207808692245660/f
Tech Design URL:
CC:
Description:
Also: https://app.asana.com/0/392891325557410/1207809241818381/f
Fixes UI test breakage by skipping assertion for title of onboarding screen.
Steps to test this PR:
.maestro/setup_ui_tests.shscript..maestro/run_ui_tests.shscript. Should consistently pass.