-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copy for onboarding highlights experiment #3325
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! left 2 teeeeeny comments
DuckDuckGo/UserText.swift
Outdated
enum Features { | ||
public static let cookiePopups = NSLocalizedString("onboarding.highlights.browsers.features.cookiePopups.title", value: "Block cookie requests & popups", comment: "Message to highlight browser capability of blocking cookie pop-ups") | ||
public static let creepyAds = NSLocalizedString("onboarding.highlights.browsers.features.creepyAds.title", value: "Block targeted ads", comment: "Message to highlight browser capability of blocking creepy ads") | ||
public static let eraseBrowsingData = NSLocalizedString("onboarding.highlights.browsers.features.eraseBrowsingData.title", value: "Erase browsing data swiftly", comment: "Message to highlight browser capability ofswiftly erase browsing data") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: ofswiftly in the comment
DuckDuckGo/UserText.swift
Outdated
|
||
enum BrowsersComparison { | ||
enum Features { | ||
public static let cookiePopups = NSLocalizedString("onboarding.highlights.browsers.features.cookiePopups.title", value: "Block cookie requests & popups", comment: "Message to highlight browser capability of blocking cookie pop-ups") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you could phrase the comment to say Message to highlight how the browser allows you to block… cause I think he intention is to be like:
Blocca gli ads! etc
Just a thought in cases helps with translations
b926980
to
c62b657
Compare
# By Alessandro Boron (2) and others # Via GitHub * main: Duckplayer Experiment Override Fix (#3329) New feature flag for autofillSurveys (#3318) Add Onboarding Progress bar (#3323) Add copy for onboarding highlights experiment (#3325) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Task/Issue URL: https://app.asana.com/0/1206329551987282/1208084960726983/f
Description:
Update the copy for Highlights experiment
Steps to test this PR:
Definition of Done (Internal Only):
Copy Testing:
’
rather than'
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template