Add copy for onboarding highlights experiment #3325
Merged
+97
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SabrinaTardio
approved these changes
Sep 6, 2024
DuckDuckGo/UserText.swift
Outdated
| enum Features { | ||
| public static let cookiePopups = NSLocalizedString("onboarding.highlights.browsers.features.cookiePopups.title", value: "Block cookie requests & popups", comment: "Message to highlight browser capability of blocking cookie pop-ups") | ||
| public static let creepyAds = NSLocalizedString("onboarding.highlights.browsers.features.creepyAds.title", value: "Block targeted ads", comment: "Message to highlight browser capability of blocking creepy ads") | ||
| public static let eraseBrowsingData = NSLocalizedString("onboarding.highlights.browsers.features.eraseBrowsingData.title", value: "Erase browsing data swiftly", comment: "Message to highlight browser capability ofswiftly erase browsing data") |
There was a problem hiding this comment.
nit: ofswiftly in the comment
DuckDuckGo/UserText.swift
Outdated
|
|
||
| enum BrowsersComparison { | ||
| enum Features { | ||
| public static let cookiePopups = NSLocalizedString("onboarding.highlights.browsers.features.cookiePopups.title", value: "Block cookie requests & popups", comment: "Message to highlight browser capability of blocking cookie pop-ups") |
There was a problem hiding this comment.
Maybe you could phrase the comment to say Message to highlight how the browser allows you to block… cause I think he intention is to be like:
Blocca gli ads! etc
Just a thought in cases helps with translations
alessandroboron
force-pushed
the
alessandro/onboarding-highlights-copy
branch
from
b926980
to
c62b657
Compare
samsymons
added a commit
that referenced
this pull request
Sep 9, 2024
# By Alessandro Boron (2) and others # Via GitHub * main: Duckplayer Experiment Override Fix (#3329) New feature flag for autofillSurveys (#3318) Add Onboarding Progress bar (#3323) Add copy for onboarding highlights experiment (#3325) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206329551987282/1208084960726983/f
Description:
Update the copy for Highlights experiment
Steps to test this PR:
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template