Add Marketplace Postback handling #3357
Conversation
| @available(iOS 16.1, *) | ||
| private func updateSKANPostback(_ postback: MarketplaceAdPostback, lockPostback: Bool) async { | ||
| do { | ||
| try await SKAdNetwork.updatePostbackConversionValue(postback.fineValue, |
There was a problem hiding this comment.
At risk of seeming like we're going backwards, what do you think about using the completion handler based API for SKAN? The reason I mention it is that we're seeing rare crashes with this call after moving to the async API. You can see an example here.
There was a problem hiding this comment.
Since we're seeing this error I believe it makes sense, then, if we still see a problem with these calls, i.e: nothing really changes, we can always revert it back to async. I'll do the change
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
# Conflicts: # DuckDuckGo/AppDelegate+Attribution.swift
| SKAdNetwork.updatePostbackConversionValue(postback.fineValue, | ||
| coarseValue: postback.SKAdCoarseValue) { error in | ||
| if let error = error { | ||
| Logger.general.error("Attribution: SKAN 4 postback failed \(String(describing: error), privacy: .public)") | ||
| } else { | ||
| Logger.general.debug("Attribution: SKAN 4 postback succeeded") | ||
| } | ||
| } |
There was a problem hiding this comment.
Since this call doesn't work on the simulator, we could wrap it in a target OS check just to reduce any error logging to the console when debugging. (This was a problem with the previous implementation as well)
# By Alessandro Boron (7) and others # Via Bartek Waresiak (1) and others * main: (31 commits) Add Marketplace Postback handling (#3357) SKAD4 crash fix (#3361) Enroll all internal users in experiment && Update BSK (#3359) update for macOS: visited links (#3353) Ensure toast closures are called on the main thread (#3347) Update survey builder OS version (#3348) BSK - Add feature flag for SKAN API (#3356) Remove checking for negative attribution case (#3355) C.S.S Bump (Via BSK) (#3346) Update Onboarding gradients (#3350) Alessandro/onboarding copy and private search options (#3349) Onboarding Intro - Add choose address bar position (#3340) Fix PrivacyDashboard appearance on entering foreground (#3345) Improve Data Store ID managing (#3335) Alessandro/onboarding choose app icon (#3330) Fix Localizable strings (#3341) Move lazy var access to the MainActor (#3333) Release 7.137.0-2 (#3344) Fix privacy icon glitch (#3343) BSK bump for macOS password import promotion flow (#3332) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Task/Issue URL: https://app.asana.com/0/72649045549333/1208126219488944/f
Tech Design URL: https://app.asana.com/0/72649045549333/1208274586553401/f
Description:
Add Marketplace Postback handling
Steps to test this PR:
0abd coarse valuelow1abd coarse valuehighAdvertising attribution report endpoint URLin the plist1 - erase all content and settings
2 - Run app
3 - Validate that the postback is not sent
4 - Set the https://jsonblob.com/api/1283828391185604608 config or remove the feature flag check
5 - Run the app again
6 - Validate that the postback is sent as a new user
1 - Remove the app
2 - Run the app again
3 - Set the https://jsonblob.com/api/1283828391185604608 config or remove the feature flag check (If you had removed the flag on code before, skip steps 4, 5 and 6)
4 - Validate that the postback is not sent
5 - Set the https://jsonblob.com/api/1283828391185604608 config or remove the feature flag check
6 - Run the app again
7 - Validate that the postback is sent as a returning user