Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pixels for adding favorites with autocomplete #3408

Draft
wants to merge 7 commits into
base: mariusz/ntp-favorites-autocomplete
Choose a base branch
from

Conversation

dus7
Copy link
Contributor

@dus7 dus7 commented Sep 27, 2024

Task/Issue URL: https://app.asana.com/0/0/1208413911032918/f
Tech Design URL:
CC:

Description:

Adds pixels reporting as described in task.

Steps to test this PR:
Verify pixels are sent according to the mentioned task on:

  1. "+" button in favorites collection is pressed.
  2. Favorite is added using autocomplete result.
  3. "Add custom website" button is pressed.
  4. Favorite is saved using custom edit.
    1. Bookmark is saved instead of favorite.
  5. Custom editing is cancelled.
  6. Started editing newly added favorite from action message.

Definition of Done (Internal Only):


Internal references:

Software Engineering Expectations
Technical Design Template

@dus7 dus7 force-pushed the mariusz/ntp-add-favorite-pixels branch from 77727e2 to af370a8 Compare September 27, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant