DuckPlayer - Add Pixel events in refactor #3470
Closed
+413
−41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208563377656004/f
Description:
Steps to test this PR:
The update pixels include new unit tests, but if you want to test the implementation, follow these steps.
Launch the app, Set DuckPlayer to 'Always'
Hit Fire Button
Search for Metallica videos
Confirm
duckplayer.view-from.serp
is firedHit Fire Button
Go to youtube.com
Search for metallica
Tap a video
Confirm
Pixel fired duckplayer.view-from.youtube.automatic
is firedHit Fire Button
Go to https://randomtests.netlify.app/ddg/duckplayer.html
Tap "Regular Youtube link"
Confirm
Pixel fired duckplayer.view-from.other
is fired