Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 'data' scheme downloads through WebKit's decisionHandler(.download) #3478

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

miasma13
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414709148257752/1208621179920770/f

Description:
When navigation should trigger download and is of data scheme handle it via decisionHandler(.download)

Steps to test this PR:

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@miasma13 miasma13 self-assigned this Oct 24, 2024
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Tested the provided test cases, as well as a range of different download types, including inline usage of data:.

@miasma13 miasma13 merged commit 9634e7f into hotfix/7.141.1 Oct 24, 2024
13 of 15 checks passed
@miasma13 miasma13 deleted the michal/hotfix-data-scheme-downloads branch October 24, 2024 17:50
samsymons added a commit that referenced this pull request Oct 24, 2024
# By Michal Smaga (1) and Sam Symons (1)
# Via GitHub
* hotfix/7.141.1:
  Release 7.141.1-0 (#3479)
  Handle 'data' scheme downloads through WebKit's `decisionHandler(.download)` (#3478)

# Conflicts:
#	Configuration/Version.xcconfig
#	DuckDuckGo/Settings.bundle/Root.plist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants