Add tests for handling of invalid rules.

duckduckgo · Oct 5, 2023 · c24af43 · c24af43
1 parent f9808c3
commit c24af43
Show file tree

Hide file tree

Showing 2 changed files with 94 additions and 0 deletions.
diff --git a/Shared (Extension)/Resources/test_rules_blocking.json b/Shared (Extension)/Resources/test_rules_blocking.json
@@ -8,5 +8,15 @@
         "condition": {
             "urlFilter": "||bad.third-party.site/*"
         }
+    },
+    {
+        "id": 10001,
+        "priority": 1,
+        "action": {
+            "type": "invalid"
+        },
+        "condition": {
+            "urlFilter": "||example.com"
+        }
     }
 ]
diff --git a/Shared (Extension)/Resources/tests/test.declarativeNetRequest.js b/Shared (Extension)/Resources/tests/test.declarativeNetRequest.js
@@ -790,4 +790,88 @@ describe("chrome.declarativeNetRequest", () => {
       }
     );
   });
+
+  it('adding unsupported DNR rules dynamically', async () => {
+    try {
+      await chrome.declarativeNetRequest.updateDynamicRules({
+        addRules: [
+          {
+            "id": 990,
+            "priority": 1,
+            "action": {
+                "type": "block"
+            },
+            "condition": {
+                "urlFilter": "||bad.third-party.site/*"
+            }
+        },
+        {
+            "id": 999,
+            "priority": 1,
+            "action": {
+                "type": "invalid"
+            },
+            "condition": {
+                "urlFilter": "||"
+            }
+        },
+        {
+          "id": 1000,
+          "priority": 1,
+          "action": {
+              "type": "block"
+          },
+          "condition": {
+              "urlFilter": "||bad.third-party.site/hello"
+          }
+        }
+      ]})
+      expect.fail('updateDynamicRules should throw')
+    } catch(e) {
+      console.log(e)
+      expect(await chrome.declarativeNetRequest.getDynamicRules()).to.have.length(0)
+    }
+  })
+
+  it('adding invalid DNR rules dynamically', async () => {
+    try {
+      await chrome.declarativeNetRequest.updateDynamicRules({
+        addRules: [
+          {
+            "id": 990,
+            "priority": 1,
+            "action": {
+                "type": "block"
+            },
+            "condition": {
+                "urlFilter": "||bad.third-party.site/*"
+            }
+        },
+        {
+            "id": 1000,
+            "priority": 1,
+            "action": {
+                "type": "block"
+            },
+            "condition": {
+                "urlFilter": "||"
+            }
+        },
+        {
+          "id": 1000,
+          "priority": 1,
+          "action": {
+              "type": "block"
+          },
+          "condition": {
+              "urlFilter": "||bad.third-party.site/hello"
+          }
+        }
+      ]})
+      expect.fail('updateDynamicRules should throw')
+    } catch(e) {
+      console.log(e)
+      expect(await chrome.declarativeNetRequest.getDynamicRules()).to.have.length(0)
+    }
+  })
 });