-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(draggable): allow ignore_dragging config option to be a function
- Loading branch information
Showing
1 changed file
with
5 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69fcfe4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature doesn't work.
ignore_dragging has always the default values - maybe it has to do with how the options are initialized:
Shouldn't it be the other way around?
Example: http://jsbin.com/fuwunuyi/4/edit
69fcfe4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! You are right!
We are using
ignore_dragging
only with Draggable and I forgot to check compatibility with Gridster.There are some Draggable options (start, stop, drag, offset_left...) defined inside Gridster that can not be overwriten to ensure Gridster works correctly. This is the reason why options are initialized in "reverse" order.
I've just pushed 6bcfa6e that fixes the problem.
Thanks for the time you are taking contributing to gridster.js!! :D