Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use BODY_LIMIT when creating app #445

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jgoz
Copy link
Contributor

@jgoz jgoz commented Oct 10, 2024

In this PR:

  • Bug fix (non-breaking change which fixes an issue)

The BODY_LIMIT env variable was being used in the content type parser, but not when creating the fastify app. This meant the practical body limit could not be raised past 50MB.

This PR uses the BODY_LIMIT var for both values.

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you lint your code with pnpm lint locally prior to submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran build with pnpm build of your changes locally?
  • Have you successfully ran tests with pnpm test of your changes locally?
  • Have you commit using Conventional Commits?

@jgoz
Copy link
Contributor Author

jgoz commented Oct 17, 2024

@matteovivona Does this change make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant