Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Github Actions to run tests #100

Merged
merged 2 commits into from
Mar 1, 2021
Merged

Use Github Actions to run tests #100

merged 2 commits into from
Mar 1, 2021

Conversation

dolfinus
Copy link
Contributor

@dolfinus dolfinus commented Feb 14, 2021

Just like #90, but instead of CircleCI it's better to use Github Actions.
Github Actions supports matrix builds (unlike Circle CI), and also allows to build really impressive CI/CD pipelines and PR/issues automatization. Here you can find more details about features.
Projects like ecto and phoenix are already moved to Github Actions.

Here you can find an example of successfully executed workflow: https://github.com/dolfinus/paginator/actions/runs/610852525

@dolfinus
Copy link
Contributor Author

@sgerrand @jbernardo95 @msz What do you think about this PR?

@sgerrand sgerrand self-requested a review March 1, 2021 02:16
@sgerrand sgerrand self-assigned this Mar 1, 2021
Copy link
Contributor

@sgerrand sgerrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! These changes look good overall. I've added a few suggestions.

One thing missing is a link to this workflow running successfully. Would you please add this, either in the description or as a comment, to make it easier for other reviewers.

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@sgerrand
Copy link
Contributor

sgerrand commented Mar 1, 2021

I think one other thing which needs to be done before this can be merged is enabling GitHub Actions on this repository and ensuring that at least 2-3 runs of this workflow complete successfully.

@sgerrand
Copy link
Contributor

sgerrand commented Mar 1, 2021

Github Actions supports matrix builds (unlike Circle CI)

Note that CircleCI has supported matrices in their builds since April 2020. I only became aware of this myself late last year.

@dolfinus
Copy link
Contributor Author

dolfinus commented Mar 1, 2021

Thank your for review!

I've added a link to a successfully executed workflow into PR description.

@dolfinus dolfinus requested a review from sgerrand March 1, 2021 15:02
Copy link
Contributor

@sgerrand sgerrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@sgerrand sgerrand merged commit 68957a2 into duffelhq:main Mar 1, 2021
@dolfinus dolfinus deleted the github_actions branch March 1, 2021 15:31
sgerrand added a commit that referenced this pull request Apr 7, 2021
When the continuous integration provider was changed by #100, the build status badge in this project's README wasn't also updated.
@sgerrand sgerrand removed their assignment Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants