Fixes bug that generates queries with cursor conditions out of order #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #68 we changed the cursor data structure from a list to a map. Because elements in a map don't have order among them, this change introduced a bug that causes paginator to generate pagination queries with the cursor conditions following the order in which they are stored in a map (which is random). This commit fixes this by enforcing the cursor_fields order on the cursor values when generating the pagination queries.
sgerrand
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #68 we changed the cursor
data structure from a list to a map. Because elements in a map don't
have order among them, this change introduced a bug that causes
paginator to generate pagination queries with the cursor conditions
following the order in which they are stored in a map (which is random).
This PR fixes this by enforcing the cursor_fields order on the
cursor values when generating the pagination queries.