-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use unicode block elements in size bar #255
Conversation
config option `style.use-old-size-bar` added to revert back to legacy size bar
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #255 +/- ##
==========================================
+ Coverage 93.50% 93.58% +0.08%
==========================================
Files 29 29
Lines 2786 2806 +20
==========================================
+ Hits 2605 2626 +21
+ Misses 140 139 -1
Partials 41 41
☔ View full report in Codecov by Sentry. |
@yurenchen000 How do you like it? |
That's awesome ✨ Thank you, I appreciate it |
Great 🙂 I will add some more tests and then merge the PR. |
@dundee - The delimiter line on RHEL6/7/8 is not showing up as line : |
This is probably more about the font used in the terminal. It probably supports just some selection of unicode block elements. |
Yup! The font that I'm using does not have the complete set of Unicode elements. I'm on Windows 10 and tested using MobaXterm & Putty. I tried 3 different fonts before raising the issue and all of them had similar problems. Changing the font to Dejavu Sans Mono fix the issue, but I think Courier New is the default font for Putty on Windows. |
Btw there is config option |
config option
style.use-old-size-bar
added to revert back to legacy size barcloses #254