-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(caddy): a command to start a PHP server #238
Conversation
b759611
to
054236e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome 🕺 I approve and second Francis' comments!
054236e
to
2412c89
Compare
I added a new |
Should it maybe be enabled by default? Maybe |
@francislavoie maybe should we choose if we want something "edge-ready" (and so, maybe should we also enable HTTPS by default, but then it will not be consistent with Currently, the commands mimic the behavior of |
"HTTPS by default" is only possible when a domain is specified anyway. That's how it works in the Caddyfile too. That's a key input that's required, since a name is needed for the SAN in the TLS cert (unless you use On-Demand TLS, but that's besides the point) |
The The Maybe FrankenPHP could work similarly. |
@mholt it currently does, but yes let's enable compression by default then! |
(We should probably update |
I'll open a PR on Caddy. |
Run
./frankenphp php-server
to serve PHP in the local directory with a production-grade server!cc @mholt @francislavoie