Package JSON fix #30
Merged
Package JSON fix #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good news. The latest fix from package-json-fix2 seems to have worked for me. Can we complete a new npm version? |
|
@mbish Looks like this needs a conflict resolved; we also need to kick the PR so CI will run again. |
|
Hi. Do you need me to test anything else for you? Be happy to help! |
AaronAtDuo
approved these changes
Mar 18, 2024
|
@rfossella Apologies for all the delays on this. We've landed the PR and I'll get a release out shortly - probably within the next day or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous solution of loading the
package.jsonfile viaimportstatement doesn't seem towork in all cases. The new solution is to prepend the directory path to
package.jsonprior toreading the file.
Motivation and Context
Some have had issues with
package.jsonnot being found during installation of this package.How Has This Been Tested?
I tested this locally and verified that the version number is reported correctly.
Types of Changes