Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to use From impl declared in JubJub and Bls repos to convert between Scalar types. #294

Closed
CPerezz opened this issue Aug 26, 2020 · 0 comments
Closed

Try to use From impl declared in JubJub and Bls repos to convert between Scalar types. #294

CPerezz opened this issue Aug 26, 2020 · 0 comments
Assignees
@ureeves
Labels
area:cryptography anything related to cryptographic primitives, hashing and ZKP good first issue Good for newcomers status:minor Low priority improvements team:R&D Research & Development (Cryptographic Protocol)
Milestone
Implementing PlonkUp

Comments

@CPerezz
Copy link
Contributor

CPerezz commented Aug 26, 2020

We have a From impl which we use across all of our repos to go from JubJubScalar -> BlsScalar. But it is not used always in this repo. And we should do it.

This was probably included in #292 & #255

See the lack of usage:

plonk/src/constraint_system/ecc/scalar_mul/fixed_base/mod.rs

Line 35 in a879624

let raw_bls_scalar = composer.variables.get(&jubjub_scalar).unwrap();

@CPerezz CPerezz added area:cryptography anything related to cryptographic primitives, hashing and ZKP type:refactor labels Aug 26, 2020
@ZER0 ZER0 added the team:R&D Research & Development (Cryptographic Protocol) label Jan 14, 2021
@CPerezz CPerezz added the good first issue Good for newcomers label Feb 1, 2021
@CPerezz CPerezz pinned this issue Feb 1, 2021
@CPerezz CPerezz added the team:Core Low Level Core Development Team (Rust) label Mar 5, 2021
@autholykos autholykos added team:R&D Research & Development (Cryptographic Protocol) and removed team:R&D Research & Development (Cryptographic Protocol) team:Core Low Level Core Development Team (Rust) labels Jul 1, 2021
@ZER0 ZER0 added this to the Implementing PlonkUp milestone Oct 6, 2021
@ZER0 ZER0 added the status:minor Low priority improvements label Oct 6, 2021
@ureeves ureeves self-assigned this Oct 15, 2021
ureeves added a commit that referenced this issue Oct 15, 2021
@ureeves
Change to use From<JubJubScalar> for BlsScalar
b56043b 
Change all conversions to `BlsScalar` from `JubJubScalar` to use the `From`
implementation.

Resolves: #294
@ureeves ureeves mentioned this issue Oct 15, 2021
Merged
ureeves added a commit that referenced this issue Oct 15, 2021
@ureeves
Change to use From<JubJubScalar> for BlsScalar (#625)
ad11e7e 
Change all conversions to `BlsScalar` from `JubJubScalar` to use the `From`
implementation.

Resolves: #294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ureeves ureeves

Labels
area:cryptography anything related to cryptographic primitives, hashing and ZKP good first issue Good for newcomers status:minor Low priority improvements team:R&D Research & Development (Cryptographic Protocol)
Projects
None yet
Milestone
Implementing PlonkUp
Development

No branches or pull requests
5 participants
@ZER0 @autholykos @CPerezz @kevaundray @ureeves