Fix deadlocks, small improvements #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -211,7 +228,7 @@ | |||
| end | |||
|
|
|||
| it "without time support should return the same time as frozen time" do | |||
| expect(@redis).to receive(:time).and_raise(Redis::CommandError) | |||
| expect(semaphore.instance_variable_get(:@redis)).to receive(:time).and_raise(Redis::CommandError) | |||
There was a problem hiding this comment.
Line is too long. [103/80]
mediaslave24
force-pushed
the
fix-deadlock
branch
from
9e1f84b
to
19d6f11
Compare
| @@ -211,7 +228,8 @@ | |||
| end | |||
|
|
|||
| it "without time support should return the same time as frozen time" do | |||
| expect(@redis).to receive(:time).and_raise(Redis::CommandError) | |||
| expect(semaphore.instance_variable_get(:@redis)).to receive(:time) | |||
| .and_raise(Redis::CommandError) | |||
There was a problem hiding this comment.
Place the . on the previous line, together with the method call receiver.
|
Hey @mediaslave24 thanks for contributing. However I found some problems with your code. Could you go through my comments and update, then I'll merge. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix deadlocks from #18.
Initialize redis after use_local_time, because use_local_time is incorrect option for redis client.
Use Enumerable#find in #locked? method for shorter code and don't shadow outer "token" variable.
Don't depend on calls to another methods in #create! (set the value right here).