feat(cb2-8776): show error message not showing above field #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniel-Searle
requested review from
shivangidas,
naathanbrown,
gjulien-bjss,
kcarr-bjss,
emilyrkelly21 and
owen-corrigan-bjss
Daniel-Searle
force-pushed
the
feature/cb2-8776
branch
from
6ce231e
to
8fe234d
Compare
feat(cb2-8776): added access descriptor feat(cb2-8776): changed date logic to be greater than -1 feat(cb2-8776): added ternary to convertToNumber logic and removed unused variable feat(cb2-8776): prevent submission when time is not provided
Daniel-Searle
force-pushed
the
feature/cb2-8776
branch
from
6fb1b9a
to
8fd67aa
Compare
kcarr-bjss
previously approved these changes
Jul 26, 2023
| @@ -29,8 +29,7 @@ export class DateValidators { | |||
|
|
|||
| private static validateTime(time: string, label: string | undefined) { | |||
| const [hours, minutes] = time.split(':'); | |||
|
|
|||
| if (!hours || !minutes) { | |||
| if (hours === '00' || minutes == '00') { | |||
There was a problem hiding this comment.
what if the test is done at 00:00? That is a valid time no?
There was a problem hiding this comment.
Is this not also implying you can't type 00 in the minutes box at all meaning all tests that are conducted on the hour will be invalid times?
There was a problem hiding this comment.
@naathanbrown checked with PO's, they're happy to proceed with the 00:00 logic
gjulien-bjss
changed the title
kcarr-bjss
previously approved these changes
Jul 31, 2023
naathanbrown
approved these changes
Jul 31, 2023
emilyrkelly21
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error message not showing above field
This PR is prevent submission when test record time is missing
CB2-8776
Checklist