Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cb2-10266): additional examiner notes date format #1327

Merged
merged 6 commits into from
Dec 15, 2023
Merged

fix(cb2-10266): additional examiner notes date format #1327

merged 6 commits into from
Dec 15, 2023

Conversation

owen-corrigan-bjss
Copy link
Contributor

cb2-10226: fix for date format and issues with template mutation

Ticket title

One line description
CB2-XXXX

Checklist

  • Branch is rebased against the latest develop/common
  • Code and UI has been tested manually after the additional changes
  • PR title includes the JIRA ticket number
  • Squashed commits contain the JIRA ticket number
  • Delete branch after merge

@owen-corrigan-bjss owen-corrigan-bjss added the bug Something isn't working label Dec 14, 2023
@owen-corrigan-bjss owen-corrigan-bjss self-assigned this Dec 14, 2023
tomcrawleyy
tomcrawleyy requested changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@tomcrawleyy tomcrawleyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, there are a few failing workflows including the tests that need fixing before merge though

@owen-corrigan-bjss owen-corrigan-bjss merged commit a4d818b into develop Dec 15, 2023
10 checks passed
@owen-corrigan-bjss owen-corrigan-bjss deleted the fix/cb2-10226 branch December 15, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivangidas shivangidas shivangidas approved these changes

@tomcrawleyy tomcrawleyy tomcrawleyy approved these changes

@pbardy2000 pbardy2000 pbardy2000 approved these changes

Assignees

@owen-corrigan-bjss owen-corrigan-bjss

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@owen-corrigan-bjss @shivangidas @tomcrawleyy @pbardy2000