Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cb2-10112): Add subsequent UN numbers #1348

Merged
merged 22 commits into from
Jan 10, 2024
Merged

feat(cb2-10112): Add subsequent UN numbers #1348

merged 22 commits into from
Jan 10, 2024

Conversation

pbardy2000
Copy link
Contributor

Add subsequent UN Numbers

  • Adds ability to add, edit, and remove UN numbers from an ADR vehicle's tech record
  • Adds new properties to form node templates to display a view mode component to render custom 'read-only' views, which follows the same syntax and structure as the existing edit mode components.
  • Rejigs the HTML structure of read-only form controls to use table to enable full-width components (properly this time)
  • Adds the updated readonly views for:
    • UN Numbers
    • TC2 inspections
    • TC3 inspections
    • Examiner notes history

The latter 3 of these have been commented out at the template level add to avoid overloading testing capacity.

CB2-10112

Checklist

  • Branch is rebased against the latest develop/common
  • Code and UI has been tested manually after the additional changes
  • PR title includes the JIRA ticket number
  • Squashed commits contain the JIRA ticket number
  • Delete branch after merge

@pbardy2000
feat(cb2-10112): allow addition of multiple UN numbers
1d46677
@pbardy2000
Merge branch 'develop' into feat/CB2-10112
2cc545f
@pbardy2000
fix(cb2-10211): fix duplicate error messages + global error service n…
0b6f355 
…ot focusing elements
@pbardy2000
Merge branch 'develop' into feat/CB2-10112
a32582d
@pbardy2000
feat(cb2-10032): better styling for readonly mode of tech records
7e2527c
@pbardy2000
feat(cb2-10032): add tc3 view mode component
d76c6fd
@pbardy2000
feat(cb2-10032): tc2 inspections
fc16d99
@pbardy2000
feat(cb2-10032): remove validation for view control
b84f0a3
@pbardy2000
fix(cb2-10174): update styling for edit component
6ca29e1
@pbardy2000
feat(cb2-10032): remove expand/collapse notes temporarily
19e68f4
@pbardy2000
fix(cb2-10211): add appropriate warnings
c16a836
@pbardy2000
Merge branch 'develop' into feat/CB2-10112
75cb352
@pbardy2000
fix(cb2-10211): fix interactions with global errors
560d428
@pbardy2000
fix(cb2-10211): update unit tests
dcebb8e
@pbardy2000
fix(cb2-10211): disable add link when you cannot add the control
f6974c6
@pbardy2000
Merge branch 'feat/cb2-10032' into feat/CB2-10112
cf6c8ab
@pbardy2000
feat(cb2-10211): add custom view mode logic
32cf6b9
@pbardy2000
feat(cb2-10211): add custom view
56f9b3a
@pbardy2000
Merge branch 'develop' into feat/CB2-10112
a2f0376
@pbardy2000
feat(cb2-10211): fix displaying of error messages
1552cbd
@github-actions github-actions bot added the enhancement New feature or request label Jan 4, 2024
@pbardy2000 pbardy2000 marked this pull request as ready for review January 4, 2024 16:53
JunYanBJSS
JunYanBJSS previously approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@JunYanBJSS JunYanBJSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having tested in my local, it looks good to me.

@pbardy2000 pbardy2000 merged commit 5c06f5a into develop Jan 10, 2024
11 checks passed
@pbardy2000 pbardy2000 deleted the feat/CB2-10112 branch January 10, 2024 09:14
@pbardy2000 pbardy2000 restored the feat/CB2-10112 branch January 10, 2024 12:28
JunYanBJSS pushed a commit that referenced this pull request Feb 26, 2024
@pbardy2000 @JunYanBJSS
feat(cb2-10112): Add subsequent UN numbers (#1348)
24078d3 
* feat(cb2-10112): allow addition of multiple UN numbers

* fix(cb2-10211): fix duplicate error messages + global error service not focusing elements

* feat(cb2-10032): better styling for readonly mode of tech records

* feat(cb2-10032): add  tc3 view mode component

* feat(cb2-10032): tc2 inspections

* feat(cb2-10032): remove validation for view control

* fix(cb2-10174): update styling for edit component

* feat(cb2-10032): remove expand/collapse notes temporarily

* fix(cb2-10211): add appropriate warnings

* fix(cb2-10211): fix interactions with global errors

* fix(cb2-10211):  update unit tests

* fix(cb2-10211): disable add link when you cannot add the control

* feat(cb2-10211): add custom view mode logic

* feat(cb2-10211): add custom view

* feat(cb2-10211): fix displaying of error messages

* feat(cb2-10211): better UX

* feat(cb2-10211): better form error displayed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivangidas shivangidas shivangidas approved these changes

@tomcrawleyy tomcrawleyy tomcrawleyy approved these changes

@JunYanBJSS JunYanBJSS JunYanBJSS left review comments

Assignees

@pbardy2000 pbardy2000

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pbardy2000 @shivangidas @tomcrawleyy @JunYanBJSS