Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/cb2-13727-2 - Folder structure refactor part 2 #1575

Merged
merged 21 commits into from
Sep 9, 2024

Conversation

tomcrawleyy
Copy link
Contributor

Ticket title

One line description
CB2-XXXX

Checklist

  • Branch is rebased against the latest develop/common
  • Code and UI has been tested manually after the additional changes
  • PR title includes the JIRA ticket number
  • Squashed commits contain the JIRA ticket number
  • Delete branch after merge

@github-actions github-actions bot added the merge conflict PR needs rebasing label Sep 6, 2024
@github-actions github-actions bot removed the merge conflict PR needs rebasing label Sep 6, 2024
@tomcrawleyy tomcrawleyy marked this pull request as ready for review September 6, 2024 14:19
Copy link
Contributor

@BrandonT95 BrandonT95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're removing the *.stories.ts files from the repo, I'd imagine we'd want to remove the .storybook directory too.

pbardy2000
pbardy2000 previously approved these changes Sep 9, 2024
pbardy2000
pbardy2000 previously approved these changes Sep 9, 2024
Copy link
Contributor

@BrandonT95 BrandonT95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some left over *.stories.ts files which for some reason the IDE isn't flagging, mainly in the app and app/features folders, but besides this happy with the functionality and improvements

@pbardy2000 pbardy2000 merged commit 1b16004 into develop Sep 9, 2024
11 checks passed
@pbardy2000 pbardy2000 deleted the feat/cb2-13727-2 branch September 9, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants