Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat(cb2-11998): repair url call to look at 1000 users page size" #23

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Revert "feat(cb2-11998): repair url call to look at 1000 users page size" #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/aad/getMemberDetails.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const getMemberDetails = async (): Promise<IMemberDetails[]> => {

const promiseArray = groupIds.map(async (groupId) => {
const requestUrl = new URL(
`/v1.0/groups/${groupId.trim()}/members?$count=true&$top=1000&$filter=accountEnabled eq true`,
`/v1.0/groups/${groupId.trim()}/members?$count=true&$filter=accountEnabled eq true`,
aadBase,
).href;

Expand Down
4 changes: 2 additions & 2 deletions tests/unit/getMemberDetails.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ describe('getMemberDetails', () => {
it('should get details from the correct url', async () => {
await getMemberDetails();
expect(mockAxiosGet).toBeCalledWith(
'https://test/v1.0/groups/testGroup/members?$count=true&$top=1000&$filter=accountEnabled%20eq%20true',
'https://test/v1.0/groups/testGroup/members?$count=true&$filter=accountEnabled%20eq%20true',
{
headers: { Authorization: 'Bearer testToken', ConsistencyLevel: 'eventual' },
},
Expand All @@ -98,7 +98,7 @@ describe('getMemberDetails', () => {
await getMemberDetails();
expect(mockAxiosGet).toBeCalledTimes(6);
expect(mockAxiosGet).toHaveBeenLastCalledWith(
'https://test/v1.0/groups/testGroup6/members?$count=true&$top=1000&$filter=accountEnabled%20eq%20true',
'https://test/v1.0/groups/testGroup6/members?$count=true&$filter=accountEnabled%20eq%20true',
{
headers: { Authorization: 'Bearer testToken', ConsistencyLevel: 'eventual' },
},
Expand Down
Loading