feat(cb2-12001): paginate AD results for test users #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcarr-bjss
approved these changes
May 31, 2024
naathanbrown
changed the title
naathanbrown
approved these changes
May 31, 2024
LGin-BJSS
commented
Jun 4, 2024
src/aad/getMemberDetails.ts
Outdated
| let users = response.data.value | ||
|
|
||
| while (response.data['@nextlink']) { | ||
| const nextlink = response.data['@nextlink'].replace('accountEnabled+eq+true', 'accountEnabled eq true') |
There was a problem hiding this comment.
This pretty ugly line is because the nextlink value that MS sends back from AD converts the spaces to + signs. The plus signs then in turn break the filter (which would mean we'd only ever do the first fetch).
There was a problem hiding this comment.
Is there a unit test in here that validates that the + are replaced?
There was a problem hiding this comment.
the unit test added in the last commit verifies it implicitly
naathanbrown
approved these changes
Jun 5, 2024
src/aad/getMemberDetails.ts
Outdated
| let users = response.data.value | ||
|
|
||
| while (response.data['@nextlink']) { | ||
| const nextlink = response.data['@nextlink'].replace('accountEnabled+eq+true', 'accountEnabled eq true') |
LGin-BJSS
commented
Jun 5, 2024
Daniel-Searle
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paginate tester results from AD
adds pagination when fetching tester results from AD
link to ticket number
Checklist