fix: VOL-3953 prevent bug with queue service from being overwritten (#…

…208)
dvsa · Aug 1, 2024 · e4c0100 · e4c0100
1 parent f5f857b
commit e4c0100
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/module/Queue/src/Service/QueueServiceTrait.php b/module/Queue/src/Service/QueueServiceTrait.php
@@ -26,23 +26,17 @@ trait QueueServiceTrait
      */
     public function setMessageBuilderService(MessageBuilder $messageBuilderService): void
     {
-        if ($this->messageBuilderService === null) {
-            $this->messageBuilderService = $messageBuilderService;
-        }
+        $this->messageBuilderService = $messageBuilderService;
     }
 
     public function setQueueService(Queue $queueService): void
     {
-        if ($this->queueService === null) {
-            $this->queueService = $queueService;
-        }
+        $this->queueService = $queueService;
     }
 
     public function setQueueConfig(array $config): void
     {
-        if ($this->queueConfig === null) {
-            $this->queueConfig = $config;
-        }
+        $this->queueConfig = $config;
     }
 
     protected function getQueueUrlKey($messageType): string

diff --git a/...src/Domain/CommandHandler/MessageQueue/Consumer/TransXChange/TransXChangeConsumerTest.php b/...src/Domain/CommandHandler/MessageQueue/Consumer/TransXChange/TransXChangeConsumerTest.php
@@ -470,5 +470,6 @@ protected function setupMocks(int $maxMessages = 100): void
         $this->s3Client->shouldReceive('getObject')->andReturn(new \Aws\Result(['Body' => '']));
 
         $this->sut->__invoke($sm, TransXChangeConsumer::class);
+        $this->sut->setQueueService($this->mockedSmServices[Queue::class]);
     }
 }