This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
feat: Subcategory support for task allocation rule and refactors #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadedvsa
previously approved these changes
Mar 18, 2024
module/Api/src/Domain/CommandHandler/TaskAllocationRule/UpdateTaskAllocationRuleTrait.php
Show resolved
Hide resolved
wadedvsa
approved these changes
Mar 18, 2024
hobbyhacker0
approved these changes
Mar 18, 2024
jerotire
added a commit
to dvsa/vol-app
that referenced
this pull request
Aug 16, 2024
…a/olcs-backend#108) * feat: Subcategory support for task allocation rule and refactors * fix: CodeSniffer * fix: revert static analysis improvements for future ticket * fix: cleaned up CreateTask command handler * chore: tests * chore: more tests * fix: static analyis findings * fix: refactor * chore: olcs-transfer bump * fix: unit tests * fix: strict types on new trait
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces support for sub category definition for task allocation rules.
Added generic types for getRepo and getReference.
Related issue: https://dvsa.atlassian.net/browse/VOL-5054
Before submitting (or marking as "ready for review")