This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
feat: resolve PHPStan issues #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fibble
approved these changes
Dec 21, 2023
ilindsay
approved these changes
Dec 21, 2023
The trait depends on `$this->getRepo()` which doesn't exist in this trait so would require this trait to be used in combination with classes that provide this method.
JoshuaLicense
force-pushed
the
migrate-to-github-part-4-phpstan
branch
from
297ff6d
to
0f4268e
Compare
fibble
added a commit
that referenced
this pull request
Mar 1, 2024
chore: replace composer deps to begin refactor # This is the commit message #2: chore: replace composer deps to begin refactor # This is the commit message #3: refactor: replace laminas-console with laminas-cli # This is the commit message #4: refactor: replace laminas-console with laminas-cli # This is the commit message #5: refactor: replace laminas-console with laminas-cli # This is the commit message #6: refactor: replace laminas-console with laminas-cli # This is the commit message #7: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #8: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #9: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #10: refactor: Tweaked result handling # This is the commit message #11: refactor: migrated more commands from BatchController # This is the commit message #12: refactor: migrated more commands from BatchController # This is the commit message #13: refactor: more cmds migrated # This is the commit message #14: refactor: some config organised, queue controllers spun out into commands. # This is the commit message #15: refactor: some fixes to config and constructor # This is the commit message #16: refactor: reorganised a bit to correct some incorrect behaviour noticed in local testing # This is the commit message #17: refactor: sorted auth/privelege escallation now running as laminas-cli not as MvcConsole request # This is the commit message #18: refactor: Intial unit test work. # This is the commit message #19: refactor: more unit test work # This is the commit message #20: refactor: further tests implemented refactor: further test implemented refactor: unit test work refactor: more unit tests created refactor: Tests, static analysis fixes. Refactored controllers removed. refactor: Tests, static analysis fixes. Refactored controllers removed. refactor: Imports optimised
fibble
added a commit
that referenced
this pull request
Mar 5, 2024
chore: replace composer deps to begin refactor # This is the commit message #2: chore: replace composer deps to begin refactor # This is the commit message #3: refactor: replace laminas-console with laminas-cli # This is the commit message #4: refactor: replace laminas-console with laminas-cli # This is the commit message #5: refactor: replace laminas-console with laminas-cli # This is the commit message #6: refactor: replace laminas-console with laminas-cli # This is the commit message #7: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #8: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #9: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #10: refactor: Tweaked result handling # This is the commit message #11: refactor: migrated more commands from BatchController # This is the commit message #12: refactor: migrated more commands from BatchController # This is the commit message #13: refactor: more cmds migrated # This is the commit message #14: refactor: some config organised, queue controllers spun out into commands. # This is the commit message #15: refactor: some fixes to config and constructor # This is the commit message #16: refactor: reorganised a bit to correct some incorrect behaviour noticed in local testing # This is the commit message #17: refactor: sorted auth/privelege escallation now running as laminas-cli not as MvcConsole request # This is the commit message #18: refactor: Intial unit test work. # This is the commit message #19: refactor: more unit test work # This is the commit message #20: refactor: further tests implemented refactor: further test implemented refactor: unit test work refactor: more unit tests created refactor: Tests, static analysis fixes. Refactored controllers removed. refactor: Tests, static analysis fixes. Refactored controllers removed. refactor: Imports optimised
fibble
added a commit
that referenced
this pull request
Mar 6, 2024
chore: replace composer deps to begin refactor # This is the commit message #2: chore: replace composer deps to begin refactor # This is the commit message #3: refactor: replace laminas-console with laminas-cli # This is the commit message #4: refactor: replace laminas-console with laminas-cli # This is the commit message #5: refactor: replace laminas-console with laminas-cli # This is the commit message #6: refactor: replace laminas-console with laminas-cli # This is the commit message #7: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #8: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #9: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #10: refactor: Tweaked result handling # This is the commit message #11: refactor: migrated more commands from BatchController # This is the commit message #12: refactor: migrated more commands from BatchController # This is the commit message #13: refactor: more cmds migrated # This is the commit message #14: refactor: some config organised, queue controllers spun out into commands. # This is the commit message #15: refactor: some fixes to config and constructor # This is the commit message #16: refactor: reorganised a bit to correct some incorrect behaviour noticed in local testing # This is the commit message #17: refactor: sorted auth/privelege escallation now running as laminas-cli not as MvcConsole request # This is the commit message #18: refactor: Intial unit test work. # This is the commit message #19: refactor: more unit test work # This is the commit message #20: refactor: further tests implemented refactor: further test implemented refactor: unit test work refactor: more unit tests created refactor: Tests, static analysis fixes. Refactored controllers removed. refactor: Tests, static analysis fixes. Refactored controllers removed. refactor: Imports optimised
fibble
added a commit
that referenced
this pull request
Mar 6, 2024
chore: replace composer deps to begin refactor # This is the commit message #2: chore: replace composer deps to begin refactor # This is the commit message #3: refactor: replace laminas-console with laminas-cli # This is the commit message #4: refactor: replace laminas-console with laminas-cli # This is the commit message #5: refactor: replace laminas-console with laminas-cli # This is the commit message #6: refactor: replace laminas-console with laminas-cli # This is the commit message #7: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #8: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #9: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #10: refactor: Tweaked result handling # This is the commit message #11: refactor: migrated more commands from BatchController # This is the commit message #12: refactor: migrated more commands from BatchController # This is the commit message #13: refactor: more cmds migrated # This is the commit message #14: refactor: some config organised, queue controllers spun out into commands. # This is the commit message #15: refactor: some fixes to config and constructor # This is the commit message #16: refactor: reorganised a bit to correct some incorrect behaviour noticed in local testing # This is the commit message #17: refactor: sorted auth/privelege escallation now running as laminas-cli not as MvcConsole request # This is the commit message #18: refactor: Intial unit test work. # This is the commit message #19: refactor: more unit test work # This is the commit message #20: refactor: further tests implemented refactor: further test implemented refactor: unit test work refactor: more unit tests created refactor: Tests, static analysis fixes. Refactored controllers removed. refactor: Tests, static analysis fixes. Refactored controllers removed. refactor: Imports optimised
fibble
added a commit
that referenced
this pull request
Mar 6, 2024
# This is the 1st commit message: # This is the 1st commit message: chore: replace composer deps to begin refactor # This is the commit message #2: chore: replace composer deps to begin refactor # This is the commit message #3: refactor: replace laminas-console with laminas-cli # This is the commit message #4: refactor: replace laminas-console with laminas-cli # This is the commit message #5: refactor: replace laminas-console with laminas-cli # This is the commit message #6: refactor: replace laminas-console with laminas-cli # This is the commit message #7: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #8: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #9: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #10: refactor: Tweaked result handling # This is the commit message #11: refactor: migrated more commands from BatchController # This is the commit message #12: refactor: migrated more commands from BatchController # This is the commit message #13: refactor: more cmds migrated # This is the commit message #14: refactor: some config organised, queue controllers spun out into commands. # This is the commit message #15: refactor: some fixes to config and constructor # This is the commit message #16: refactor: reorganised a bit to correct some incorrect behaviour noticed in local testing # This is the commit message #17: refactor: sorted auth/privelege escallation now running as laminas-cli not as MvcConsole request # This is the commit message #18: refactor: Intial unit test work. # This is the commit message #19: refactor: more unit test work # This is the commit message #20: refactor: further tests implemented refactor: further test implemented refactor: unit test work refactor: more unit tests created refactor: Tests, static analysis fixes. Refactored controllers removed. refactor: Tests, static analysis fixes. Refactored controllers removed. refactor: Imports optimised # This is the commit message #2: refactor: unit test fixes # This is the commit message #3: refactor: composer dev dep removed # This is the commit message #4: fix: noticed literal issue in log/cli status print # This is the commit message #5: fix: noticed literal issue in log/cli status print # This is the commit message #6: chore: updating lockfile # This is the commit message #7: chore: updating lockfile abd adding dev-dependency for test build # This is the commit message #8: # This is the 1st commit message: chore: replace composer deps to begin refactor # This is the commit message #2: chore: replace composer deps to begin refactor # This is the commit message #3: refactor: replace laminas-console with laminas-cli # This is the commit message #4: refactor: replace laminas-console with laminas-cli # This is the commit message #5: refactor: replace laminas-console with laminas-cli # This is the commit message #6: refactor: replace laminas-console with laminas-cli # This is the commit message #7: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #8: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #9: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #10: refactor: Tweaked result handling # This is the commit message #11: refactor: migrated more commands from BatchController # This is the commit message #12: refactor: migrated more commands from BatchController # This is the commit message #13: refactor: more cmds migrated # This is the commit message #14: refactor: some config organised, queue controllers spun out into commands. # This is the commit message #15: refactor: some fixes to config and constructor # This is the commit message #16: refactor: reorganised a bit to correct some incorrect behaviour noticed in local testing # This is the commit message #17: refactor: sorted auth/privelege escallation now running as laminas-cli not as MvcConsole request # This is the commit message #18: refactor: Intial unit test work. # This is the commit message #19: refactor: more unit test work # This is the commit message #20: refactor: further tests implemented refactor: further test implemented refactor: unit test work refactor: more unit tests created refactor: Tests, static analysis fixes. Refactored controllers removed. refactor: Tests, static analysis fixes. Refactored controllers removed. refactor: Imports optimised # This is the commit message #9: refactor: unit test fixes # This is the commit message #10: refactor: composer dev dep removed # This is the commit message #11: fix: noticed literal issue in log/cli status print # This is the commit message #12: fix: noticed literal issue in log/cli status print # This is the commit message #13: chore: updating lockfile # This is the commit message #14: chore: updating lockfile abd adding dev-dependency for test build # This is the commit message #15: chore: updating lockfile abd adding dev-dependency for test build # This is the commit message #16: # This is the 1st commit message: chore: replace composer deps to begin refactor # This is the commit message #2: chore: replace composer deps to begin refactor # This is the commit message #3: refactor: replace laminas-console with laminas-cli # This is the commit message #4: refactor: replace laminas-console with laminas-cli # This is the commit message #5: refactor: replace laminas-console with laminas-cli # This is the commit message #6: refactor: replace laminas-console with laminas-cli # This is the commit message #7: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #8: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #9: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #10: refactor: Tweaked result handling # This is the commit message #11: refactor: migrated more commands from BatchController # This is the commit message #12: refactor: migrated more commands from BatchController # This is the commit message #13: refactor: more cmds migrated # This is the commit message #14: refactor: some config organised, queue controllers spun out into commands. # This is the commit message #15: refactor: some fixes to config and constructor # This is the commit message #16: refactor: reorganised a bit to correct some incorrect behaviour noticed in local testing # This is the commit message #17: refactor: sorted auth/privelege escallation now running as laminas-cli not as MvcConsole request # This is the commit message #18: refactor: Intial unit test work. # This is the commit message #19: refactor: more unit test work # This is the commit message #20: refactor: further tests implemented refactor: further test implemented refactor: unit test work refactor: more unit tests created refactor: Tests, static analysis fixes. Refactored controllers removed. refactor: Tests, static analysis fixes. Refactored controllers removed. refactor: Imports optimised refactor: unit test fixes refactor: composer dev dep removed fix: noticed literal issue in log/cli status print fix: noticed literal issue in log/cli status print chore: updating lockfile chore: updating lockfile abd adding dev-dependency for test build # This is the 1st commit message: chore: replace composer deps to begin refactor # This is the commit message #2: chore: replace composer deps to begin refactor # This is the commit message #3: refactor: replace laminas-console with laminas-cli # This is the commit message #4: refactor: replace laminas-console with laminas-cli # This is the commit message #5: refactor: replace laminas-console with laminas-cli # This is the commit message #6: refactor: replace laminas-console with laminas-cli # This is the commit message #7: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #8: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #9: refactor: near-identical factory boilerplate was bloating, moved to ConfigAbstractFactory for these commands. # This is the commit message #10: refactor: Tweaked result handling # This is the commit message #11: refactor: migrated more commands from BatchController # This is the commit message #12: refactor: migrated more commands from BatchController # This is the commit message #13: refactor: more cmds migrated # This is the commit message #14: refactor: some config organised, queue controllers spun out into commands. # This is the commit message #15: refactor: some fixes to config and constructor # This is the commit message #16: refactor: reorganised a bit to correct some incorrect behaviour noticed in local testing # This is the commit message #17: refactor: sorted auth/privelege escallation now running as laminas-cli not as MvcConsole request # This is the commit message #18: refactor: Intial unit test work. # This is the commit message #19: refactor: more unit test work # This is the commit message #20: refactor: further tests implemented refactor: further test implemented refactor: unit test work refactor: more unit tests created refactor: Tests, static analysis fixes. Refactored controllers removed. refactor: Tests, static analysis fixes. Refactored controllers removed. refactor: Imports optimised refactor: unit test fixes refactor: composer dev dep removed fix: noticed literal issue in log/cli status print fix: noticed literal issue in log/cli status print chore: updating lockfile chore: updating lockfile abd adding dev-dependency for test build chore: updating lockfile abd adding dev-dependency for test build
jerotire
pushed a commit
to dvsa/vol-app
that referenced
this pull request
Aug 16, 2024
* fix: remove `NamingServiceAwareTraitTest` due to over-coupling The trait depends on `$this->getRepo()` which doesn't exist in this trait so would require this trait to be used in combination with classes that provide this method. * fix: resolve various PHPStan issues * chore: bump `olcs-transfer` * fix: correctly type the DeclarationTest `ApplicationUndertakings` mock * fix: assertEmpty on `ConditionsUndertakingsReviewService` instead of `null` * chore: add `public` and `config` directory to PHPStan scope
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves the identified PHPStan issues.