Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

fix: remove transport manager address optimistic lock #149

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

wadedvsa
Copy link
Contributor

Description

Refresh address before delete as it may have changed further up the stack.

Related issue: VOL-3410

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@wadedvsa wadedvsa changed the base branch from main to php74 April 18, 2024 10:14
jerotire
jerotire previously approved these changes Apr 18, 2024
@wadedvsa wadedvsa changed the base branch from php74 to main April 18, 2024 12:22
@wadedvsa wadedvsa dismissed jerotire’s stale review April 18, 2024 12:22

The base branch was changed.

@wadedvsa wadedvsa force-pushed the bugfix/VOL-3410-remove-transport-manager-lock branch from 48e6bb4 to d03734a Compare April 18, 2024 12:23
@wadedvsa wadedvsa merged commit 420ad43 into main Apr 22, 2024
6 checks passed
@wadedvsa wadedvsa deleted the bugfix/VOL-3410-remove-transport-manager-lock branch April 22, 2024 09:40
jerotire pushed a commit to dvsa/vol-app that referenced this pull request Aug 16, 2024
…end#149)

* fix: Allow removal of transport manager address

* fix: Test fix

* fix: Unit tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants