This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
fix: Psalm & Redis IGBinary issue #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerotire
requested review from
JoshuaLicense,
fibble,
hobbyhacker0,
ilindsay and
gabrielg2020
fibble
approved these changes
Jun 26, 2024
JoshuaLicense
approved these changes
Jun 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the CI workflow where Psalm now fails because PHP does not have Redis with IGBinary extension enabled (thus constant did not exist).
As a temporary measure, we copy-pasta the Static Analysis workflow from dvsa/.github/workflows/php-static.yml and modify Setup PHP to compile Redis from source with support for IGBinary.
Related issue: https://dvsa.atlassian.net/browse/VOL-5559
Before submitting (or marking as "ready for review")