Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

feat: Use translation key in close popup #114

Merged
merged 1 commit into from
Mar 12, 2024
Merged

feat: Use translation key in close popup #114

merged 1 commit into from
Mar 12, 2024

Conversation

wadedvsa
Copy link
Contributor

Description

Use translations in close popup.

Related issue: VOL-5121

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@wadedvsa wadedvsa merged commit e6dd845 into main Mar 12, 2024
3 of 6 checks passed
@wadedvsa wadedvsa deleted the feature/VOL-5121-translation-key-for-close-popup branch March 12, 2024 09:52
@github-actions github-actions bot mentioned this pull request Mar 12, 2024
Open
jerotire pushed a commit to dvsa/vol-app that referenced this pull request Aug 16, 2024
@wadedvsa
feat: Use translation key in close popup (dvsa/olcs-internal#114)
def1bee
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fibble fibble fibble approved these changes

@hobbyhacker0 hobbyhacker0 hobbyhacker0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wadedvsa @fibble @hobbyhacker0