This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
refactor!: VOL-4762 olcs-internal now PHP 8 compatible #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fibble
approved these changes
May 1, 2024
jerotire
approved these changes
May 1, 2024
jerotire
pushed a commit
to dvsa/vol-app
that referenced
this pull request
Aug 16, 2024
…ernal#156) * refactor!: require php 8, bump dependencies to php8 compatible versions * refactor: remove incorrect return types for Laminas ConsoleModel * refactor!: run rector PHP 8.0 ruleset * refactor: fix tests to work with extra type checking from updated dependencies * chore: update CI to use PHP 8.0 * fix: skip ConversationTest for now, refactor ticket raised VOL-5357 * refactor: fix phpcs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
olcs-internal is now PHP 8 compatible subject to testing. CI passing.
Related issue: VOL-4762